Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Adam Ford <aford173@gmail.com>,
        "S.j. Wang" <shengjiu.wang@nxp.com>
CC:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Sascha Hauer <kernel@pengutronix.de>,
        arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node
Thread-Topic: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node
Thread-Index: AQHW3duJvPuYDUtWdEOkXpLhy092Y6oOAAGAgAA/DACAAK1T8A==
Date:   Wed, 30 Dec 2020 02:34:06 +0000
Message-ID: <DB6PR0402MB2760BBFAAA6C5CE0373EDEFE88D70@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <1609243245-9671-1-git-send-email-peng.fan@nxp.com>
 <1609243245-9671-3-git-send-email-peng.fan@nxp.com>
 <CAHCN7x+=ebLn8vrrT=fyByQDydDNfkESFZHjdUrw=OHBz_E0hw@mail.gmail.com>
 <20201229161220.GA17229@kozik-lap>
In-Reply-To: <20201229161220.GA17229@kozik-lap>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ba403243-b72a-4323-e352-08d8ac6b612e
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Dec 2020 02:34:06.3416
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WiYJ++iV5jtcGOfvG0Zcq6uYS666yOg2RzN2hzgZ6E9lanc8SzXUElZUip3KgP1k1D7vMIpCkjbtvmf5TcmsDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5996
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node
>=20
> On Tue, Dec 29, 2020 at 06:26:41AM -0600, Adam Ford wrote:
> > On Tue, Dec 29, 2020 at 6:15 AM <peng.fan@nxp.com> wrote:
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > According to RM, there is a spba bus inside aips3 and aips1, add it.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 362
> > > +++++++++++-----------
> > >  1 file changed, 189 insertions(+), 173 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > index c824f2615fe8..91f85b8cee9a 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > @@ -269,117 +269,125 @@ aips1: bus@30000000 {
> > >                         #size-cells =3D <1>;
> > >                         ranges =3D <0x30000000 0x30000000
> 0x400000>;
> > >
> > > -                       sai1: sai@30010000 {
> > > -                               #sound-dai-cells =3D <0>;
> > > -                               compatible =3D "fsl,imx8mm-sai",
> "fsl,imx8mq-sai";
> > > -                               reg =3D <0x30010000 0x10000>;
> > > -                               interrupts =3D <GIC_SPI 95
> IRQ_TYPE_LEVEL_HIGH>;
> > > -                               clocks =3D <&clk
> IMX8MM_CLK_SAI1_IPG>,
> > > -                                        <&clk
> IMX8MM_CLK_SAI1_ROOT>,
> > > -                                        <&clk
> IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>;
> > > -                               clock-names =3D "bus", "mclk1",
> "mclk2", "mclk3";
> > > -                               dmas =3D <&sdma2 0 2 0>, <&sdma2
> 1 2 0>;
> > > -                               dma-names =3D "rx", "tx";
> > > -                               status =3D "disabled";
> > > -                       };
> > > +                       bus@30000000 {
> >
> > There is already a bus@30000000 (aips1), and I think the system
> > doesn't like it when there are multiple busses with the same name.
> >
> > There was some discussion on fixing the 8mn [1], but it doesn't look
> > like it went anywhere.
> >
> > I am guessing the Mini will need something similar to the nano.
> >
> > [1] -
> > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpat=
c
> >
> hwork.kernel.org%2Fproject%2Flinux-arm-kernel%2Fpatch%2F1607324004-1
> 29
> >
> 60-1-git-send-email-shengjiu.wang%40nxp.com%2F&amp;data=3D04%7C01%7
> Cpeng
> > .fan%40nxp.com%7C970d320f3ef7413296ed08d8ac1486f9%7C686ea1d3bc
> 2b4c6fa9
> >
> 2cd99c5c301635%7C0%7C0%7C637448551481206715%7CUnknown%7CTW
> FpbGZsb3d8ey
> >
> JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7C200
> >
> 0&amp;sdata=3DxKgYHCDyitbUyTPKVuwQV%2FCoJvepCbdBJ1MD9vP%2B6MY
> %3D&amp;res
> > erved=3D0
>=20
> Several replies from S.j. Wang are missing from LKML (and maybe
> patchwork?) but we reached a conclusion:

Thanks for the pointing, I'll give a look. If S.J take it, I'll leave it to=
 S.J.

Thanks,
Peng.=20

> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flore.=
ke
> rnel.org%2Flinux-arm-kernel%2F20201208090601.GA8347%40kozik-lap%2F&
> amp;data=3D04%7C01%7Cpeng.fan%40nxp.com%7C970d320f3ef7413296ed08
> d8ac1486f9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63744
> 8551481206715%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;sdata=3Dnk
> t0J5RtzA%2B29nK4aPnd434FNQV8MUZ%2F8Aq64o6hl6I%3D&amp;reserved
> =3D0
>=20
> Either you do some remapping of address space or just rename the "bus"
> nodes (e.g. generic bus-1 or a specific spba-bus).
>=20
> Best regards,
> Krzysztof