Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1609311551-97108-1-git-send-email-abaci-bugfix@linux.alibaba.com>
In-Reply-To: <1609311551-97108-1-git-send-email-abaci-bugfix@linux.alibaba.com>
From:   Muchun Song <smuchun@gmail.com>
Date:   Wed, 30 Dec 2020 15:10:25 +0800
Message-ID: <CAPSr9jG53xF=9BEYe4phGuyPK7yrtCB57mDwRHzb0s7ic2sGyA@mail.gmail.com>
Subject: Re: [PATCH] mm: fix: Uninitialized variable ret.
To:     YANG LI <abaci-bugfix@linux.alibaba.com>
Cc:     hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com,
        akpm@linux-foundation.org, cgroups@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

YANG LI <abaci-bugfix@linux.alibaba.com> =E4=BA=8E2020=E5=B9=B412=E6=9C=883=
0=E6=97=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=883:02=E5=86=99=E9=81=93=EF=BC=
=9A
>
> The ret is being used but it isn't being initialized,
> need to assign a value to it, like 0.

Hi Yang,

I didn't see where it was used without initialized.
Can you point that out to me?

Thanks.


>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci <abaci@linux.alibaba.com>
> ---
>  mm/memcontrol.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 605f671..15ba17d 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3366,7 +3366,7 @@ static int mem_cgroup_resize_max(struct mem_cgroup =
*memcg,
>  {
>         bool enlarge =3D false;
>         bool drained =3D false;
> -       int ret;
> +       int ret =3D 0;
>         bool limits_invariant;
>         struct page_counter *counter =3D memsw ? &memcg->memsw : &memcg->=
memory;
>
> --
> 1.8.3.1
>