Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6c27906cf7f67a4fc39f2d3898fb843005f1e4e6.camel@dylanvanassche.be>
Subject: Re: [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64,
 pinephone' to the compatible list
From:   Dylan Van Assche <me@dylanvanassche.be>
To:     Chen-Yu Tsai <wens@csie.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date:   Wed, 30 Dec 2020 11:41:56 +0100
In-Reply-To: <CAGb2v67C+hQyqjrx9A9MiyjEQdeVv+9BgrzxcuiHwf2e8JTswg@mail.gmail.com>
References: <20201229154106.4867-1-me@dylanvanassche.be>
         <CAGb2v67C+hQyqjrx9A9MiyjEQdeVv+9BgrzxcuiHwf2e8JTswg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Good point!
I will send a new version of the patch soon.

Kind regards,
Dylan Van Assche

On Wed, 2020-12-30 at 17:38 +0800, Chen-Yu Tsai wrote:
> On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche <
> me@dylanvanassche.be> wrote:
> > All revisions of the PinePhone share most of the hardware.
> > This patch makes it easier to detect PinePhone hardware without
> > having to check for each possible revision.
> 
> Sounds good.
> 
> > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
> 
> Please also update the DT binding file:
> 
>     Documentation/devicetree/bindings/arm/sunxi.yaml
> 
> ChenYu