Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <aaac7b17d6cae4815602e5b8383254a6287a28af.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: ignore warning designated initializers
 using NR_CPUS
From:   Joe Perches <joe@perches.com>
To:     Peng Wang <rocking@linux.alibaba.com>, apw@canonical.com,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org
Date:   Wed, 30 Dec 2020 04:16:44 -0800
In-Reply-To: <334ce7b5136e25bd4b10309abc36c18d75bb0d33.1609311092.git.rocking@linux.alibaba.com>
References: <5ca6c2d28f6cf091a676f8e7d8f14a933da0b267.camel@perches.com>
         <334ce7b5136e25bd4b10309abc36c18d75bb0d33.1609311092.git.rocking@linux.alibaba.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2020-12-30 at 15:14 +0800, Peng Wang wrote:
> Some max_length wants to hold as large room as possible to
> ensure enough size to tackle with the biggest NR_CPUS.
> An example below:
> 
> kernel/cgroup/cpuset.c:
> static struct cftype legacy_files[] = {
> ????????{
> ????????????????.name = "cpus",
> ????????????????.seq_show = cpuset_common_seq_show,
> ????????????????.write = cpuset_write_resmask,
> ????????????????.max_write_len = (100U + 6 * NR_CPUS),
> ????????????????.private = FILE_CPULIST,
> ????????},
> 	...
> }
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -7022,12 +7022,15 @@ sub process {
> ?
> 
> ?# use of NR_CPUS is usually wrong
> ?# ignore definitions of NR_CPUS and usage to define arrays as likely right
> +# ignore designated initializers using NR_CPUS
> +

Please remove this empty line, other than that, looks OK to me.

Andrew?  Care to take this and remove the empty line or wait for v3?

> ?		if ($line =~ /\bNR_CPUS\b/ &&
> ?		    $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
> ?		    $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
> ?		    $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
> ?		    $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
> -		    $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
> +		    $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/ &&
> +		    $line !~ /^.\s*\.\w+\s*=\s*.*\bNR_CPUS\b/)
> ?		{
> ?			WARN("NR_CPUS",
> ?			     "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);