Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201228125020.963311703@linuxfoundation.org> <20201228125046.214023397@linuxfoundation.org>
 <20201230122508.GA12190@duo.ucw.cz>
In-Reply-To: <20201230122508.GA12190@duo.ucw.cz>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 30 Dec 2020 14:32:46 +0200
Message-ID: <CAHp75VdFT-SUUj2LiPTs1_RJ-n97OiyQ2pF0jVbHsARkDshfwA@mail.gmail.com>
Subject: Re: [PATCH 5.10 527/717] media: ipu3-cio2: Validate mbus format in
 setting subdev format
To:     Pavel Machek <pavel@denx.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Stable <stable@vger.kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 30, 2020 at 2:25 PM Pavel Machek <pavel@denx.de> wrote:

> > commit a86cf9b29e8b12811cf53c4970eefe0c1d290476 upstream.
> >
> > Validate media bus code, width and height when setting the subdev format.
> >
> > This effectively reworks how setting subdev format is implemented in the
> > driver.
>
> Something is wrong here:
>
> > +     fmt->format.code = formats[0].mbus_code;
> > +     for (i = 0; i < ARRAY_SIZE(formats); i++) {

Looks like 'i = 1' should be...

> > +             if (formats[i].mbus_code == fmt->format.code) {
> > +                     fmt->format.code = mbus_code;
> > +                     break;
> > +             }
>
> This does not make sense. Loop will always exit during the first
> iteration, making the whole loop crazy/redundant.


-- 
With Best Regards,
Andy Shevchenko