Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 30 Dec 2020 13:14:02 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Tim Harvey <tharvey@gateworks.com>
Cc:     "Rafael J . Wysocki" <rafael@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        open list <linux-kernel@vger.kernel.org>,
        Laxminath Kasam <lkasam@codeaurora.org>,
        Tony Lindgren <tony@atomide.com>,
        Lee Jones <lee.jones@linaro.org>,
        Robert Jones <rjones@gateworks.com>
Subject: Re: [PATCH] regmap: irq: do not allow setting irq bits during ack
Message-ID: <20201230131402.GA4428@sirena.org.uk>
References: <1609191951-15590-1-git-send-email-tharvey@gateworks.com>
 <20201229130629.GD4786@sirena.org.uk>
 <CAJ+vNU3hWOdXUoogCH0U_WvYaMMaFBYs8D30KEg96ctgkhBqyQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/"
Content-Disposition: inline
In-Reply-To: <CAJ+vNU3hWOdXUoogCH0U_WvYaMMaFBYs8D30KEg96ctgkhBqyQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 29, 2020 at 08:23:00AM -0800, Tim Harvey wrote:
> On Tue, Dec 29, 2020 at 5:06 AM Mark Brown <broonie@kernel.org> wrote:

> > I can't understand what this commit message is trying to say, sorry.
> > Which bits are you talking about when you say "if bits are set"?  Isn't
> > acknowleding the interrupt clearing the bits asserting the interrupt?  I
> > can't tell what the problem you're trying to fix is.

> If for example status=0x01 the current code for ack_invert will write
> a 0xfe to clear that bit which ends up setting all other interrupt
> bits keeping the interrupt from ever being de-asserted. With the patch
> applied a status=0x01 will result in a 0x00 written to clear that bit
> and keep other's from being set.

But that's not an inverted ack as far as I can see?  That's writing back
the bit you're trying to clear which is the default ack.  Why do you
believe this is an inverted ack?  In any case the changelog for the
patch needs to be clear.

--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/sfRkACgkQJNaLcl1U
h9Dtngf+PfNgCnvF4MCWZrEmFoPjuACYzqTyBE4kjzySkcrVNlzaiycSICYWjq27
Yp2nAXT824UsZgX3N6dem4QhSy9uoDHdri9QsfsBzi1BV6GefjscdUIQv/8e7ygw
QSaF0tLJA9ciO6cwrqR4YPpnWw91vRMIw4ngMQa1/vrDHxNn/XbwpOCiKwFoyEyx
jd3fiBRt72k/hmqCdPBGDMbs+JHgYjgGasNxjHkxKI1xf8Z9bv9A3py4ltso2PQz
IaX9C7sRRtAWY1D43FKBdUq7KnU4ly67fhQ2CvQUO6mT10b4tA9/+j0ShrewjloH
bJxDKMqAyQ1FXZmDZcFqK23EFINGUw==
=Dmq2
-----END PGP SIGNATURE-----

--pWyiEgJYm5f9v55/--