Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbWIGLG5 (ORCPT ); Thu, 7 Sep 2006 07:06:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751652AbWIGLG5 (ORCPT ); Thu, 7 Sep 2006 07:06:57 -0400 Received: from natreg.rzone.de ([81.169.145.183]:46056 "EHLO natreg.rzone.de") by vger.kernel.org with ESMTP id S1751656AbWIGLGz (ORCPT ); Thu, 7 Sep 2006 07:06:55 -0400 Date: Thu, 7 Sep 2006 13:05:13 +0200 From: Olaf Hering To: Kirill Korotaev Cc: Andrew Morton , Linux Kernel Mailing List , Andrey Mirkin , devel@openvz.org, mikpe@it.uu.se, sam@ravnborg.org, bunk@stusta.de Subject: Re: [PATCH] fail kernel compilation in case of unresolved symbols (v2) Message-ID: <20060907110513.GA22319@aepfle.de> References: <44FFEE5D.2050905@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <44FFEE5D.2050905@openvz.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 21 On Thu, Sep 07, Kirill Korotaev wrote: > At stage 2 modpost utility is used to check modules. > In case of unresolved symbols modpost only prints warning. > > IMHO it is a good idea to fail compilation process in case of > unresolved symbols (at least in modules coming with kernel), > since usually such errors are left unnoticed, but kernel > modules are broken. It clearly depends on the context. An unimportant dvb module may have unresolved symbols, but the drivers for your root filesystem should rather not have unresolved symbols. Better leave the current default, your patch seems to turn an unresolved symbol with "unknown importance" into a hard error. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/