Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp10633965pxu; Wed, 30 Dec 2020 07:34:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyogov/HKCXss9CLjKmLceJTy6Qw1uP6+p9gwcvKCFk9EUHKkEocQQ+TdwCK+hJy3NN3QAc X-Received: by 2002:a05:6402:407:: with SMTP id q7mr51036291edv.312.1609342459000; Wed, 30 Dec 2020 07:34:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609342458; cv=none; d=google.com; s=arc-20160816; b=b431TlZZslbclj6vU8jivveyiOxtDzdv/Kllz//wxpbmw8XnEzznm1C9IgJtL/tYeS rs98UDd7u2b6+RDTp2e1yhroP6XccebQftlOlwEvW4O/4Ujujsov7FfMkCX8w226wc/v qE36n+Qwn3MT55aARiUSWbZgJQ9ncSa4bdqluxxsy/bTQ9QApXr37u3xD7QUO9LhpWDl evXUzAcHLGDO+VP4e+hB9Huo9vtpSYdr7mcznIOQ4Y+YmZ2HUVHhgGk9XEFpBOUVXpvT Z7+67RMpAWiYQYWIQqbC8u27ZrQyMe4nzlWwzXp8J7NEDge4clp0nuNc2M4/vaK/FJd8 0pYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=e4gWcmQQTZJtH98PQSmAJGyDoB+Ik1IsaTOp5ihNFxk=; b=hLvPj+W8vI7jScF2a7q1sbiJpRBpoD7wm85RknyTVdjYSNSbUL65zt3osfwxp9AvM3 905nAFRETAy6oNOMn0Wx30+xztvNY3tLLg0ovmseQtXJqomR05kx8yJzUCo6vUDEfkz+ 0l1/7LrUk+bYSIaUJTxND14yrWsRT7UXaevcbBqQKNvuBVZdP1vyn6e+QeChkfmEJa67 wx5WkKoYYcOgd8+/+fNuxvSn0HD29Rv0sOW46gu3Tz0DYSdTbTww+oAID2vjVc8Uo/Qu GNZLCjYXCPOrUqFB8dCP9CCHt9e033SsY/rzG5bDOt8YN1QmPJyuxDlTShMkhgkdCnaq LDtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si23009197ejg.492.2020.12.30.07.33.56; Wed, 30 Dec 2020 07:34:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726602AbgL3PcU (ORCPT + 99 others); Wed, 30 Dec 2020 10:32:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:47258 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbgL3PcT (ORCPT ); Wed, 30 Dec 2020 10:32:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 83B7EABA1; Wed, 30 Dec 2020 15:31:38 +0000 (UTC) Date: Wed, 30 Dec 2020 16:31:38 +0100 From: Daniel Wagner To: Hannes Reinecke Cc: Sagi Grimberg , Enzo Matsumiya , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Jens Axboe , Keith Busch , Christoph Hellwig Subject: Re: [PATCH] nvme: hwmon: fix crash on device teardown Message-ID: <20201230153138.4f2jd2yd2vkqndby@beryllium.lan> References: <20201209213228.5044-1-ematsumiya@suse.de> <4ebb1b8c-4bb0-6ebf-3417-d4aee1bdd3a8@suse.de> <20201230143805.2v4izgkzbnisssvr@beryllium.lan> <20201230151653.ozlqlwef7f2tarwz@beryllium.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230151653.ozlqlwef7f2tarwz@beryllium.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2020 at 04:16:53PM +0100, Daniel Wagner wrote: > I've attached the hwmon to the nvme object, which fixes the obvious > problem. But I still don't see any 'DEVRES REM' message. This would > indicate the nvme object never really goes away... more debugging... Stupid me, the nvme device is not managed by devm.