Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp10758536pxu; Wed, 30 Dec 2020 10:45:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJzz63Q0r4YicfyB/+KqL9LNc2oTCvnlh02XvejU7lA0/pZoK+EBIo1lOY6nop1Gg8QQ9EBu X-Received: by 2002:aa7:dac5:: with SMTP id x5mr52668788eds.198.1609353954484; Wed, 30 Dec 2020 10:45:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609353954; cv=none; d=google.com; s=arc-20160816; b=qNtnvT6rw5RYn4Ecpv/Jm/AQkpIVgf7tYRFrbUKC1LneEVzY/NrBrRCHW8EIQ7gIO9 xF7kxN8g3ixg0JQQ2wvdHStY2cfJT8u5XME6LE7M9fbrnWchIVAZ4vEcP5nx5wga0pTZ BJZqbKt3VAqD2EwsBkd8BJAqzQRVdoMeaXU6+PVNRIFqzNARGHGOgjAOvqzlXbGQP1Be 4YfxC91VqAdd11bIcS/caNHIH2PBzFrATZ0DmE0sK2pEgRyEIo8SvlvDcl0/+xrqSBLJ py6d6UkKyCULZE7t3ISWhKqS9bkfKEC57w8bJzXLdZEMS82zFTKDAOcBqGlJmu+LOPZ1 0J3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=o7qVY+1dOSe2GQzY5cAhUHXRvIFXuMRTPqfkocYXpjo=; b=czfjVpeX9/YYHC2Zy1s6cxQhCNZvwy6vq8AsRmiDlSdlbUAMBUOVpqJiRG1K/G5ZGq HdDpHn7Z62kbJM5iB6uyW1QuoAXZ/gWDerWyU0BWGLl9yeb6OfVDh8v6jiN8jSCrr7Py SNY9ETTyIDVR6Xt3BugBz1NCidObXpVodoHkSE8hgF72+6XhN9Vu1576IwR6/Xv+Cr5+ Yzn826zQgLmrWKSm0wvKC6XGnI6p9/ccp+IimfLIYgLVGOWj5IN1+yGcvPhOYw4PUNxs BV8hFt3NDu7f92Gxlw4lbcXb0c0CPyrVudtp14VOH9s5nxQuih6/uFB3nhujo1+MduXs MHYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs26si21267673ejc.229.2020.12.30.10.45.09; Wed, 30 Dec 2020 10:45:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726360AbgL3Sn0 (ORCPT + 99 others); Wed, 30 Dec 2020 13:43:26 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:53660 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgL3SnZ (ORCPT ); Wed, 30 Dec 2020 13:43:25 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 2D0DA1C0B79; Wed, 30 Dec 2020 19:42:43 +0100 (CET) Date: Wed, 30 Dec 2020 19:42:42 +0100 From: Pavel Machek To: Andrea Righi Cc: Boqun Feng , Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: trigger: fix potential deadlock with libata Message-ID: <20201230184242.GA25903@duo.ucw.cz> References: <20201125151822.GB73489@xps-13-7390> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: <20201125151822.GB73489@xps-13-7390> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Apply the same change to led_trigger_blink_setup() as well, since the > same deadlock scenario can also happen in power_supply_update_bat_leds() > -> led_trigger_blink() -> led_trigger_blink_setup() (workqueue context), > and potentially prevent other similar usages. Thanks, applied. Pavel --=20 http://www.livejournal.com/~pavelmachek --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX+zKIgAKCRAw5/Bqldv6 8jTaAKCrKQ7L8oRfkIzzYXZAJO19FZ5m8gCgpVytYIxoeWApCsBdJx5z2G6nqmU= =c1r0 -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--