Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 30 Dec 2020 19:12:40 +0000
From:   Russell King - ARM Linux admin <linux@armlinux.org.uk>
To:     Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>
Cc:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are
 detected as SFF
Message-ID: <20201230191240.GX1551@shell.armlinux.org.uk>
References: <20201230154755.14746-1-pali@kernel.org>
 <20201230154755.14746-3-pali@kernel.org>
 <20201230161151.GS1551@shell.armlinux.org.uk>
 <20201230170652.of3m226tidtunslm@pali>
 <20201230182707.4a8b13d0@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201230182707.4a8b13d0@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Precedence: bulk

On Wed, Dec 30, 2020 at 06:27:07PM +0100, Marek Beh?n wrote:
> On Wed, 30 Dec 2020 18:06:52 +0100
> Pali Roh?r <pali@kernel.org> wrote:
> 
> > 	if (!sfp->type->module_supported(&id) &&
> > 	    (memcmp(id.base.vendor_name, "UBNT            ", 16) ||
> > 	     memcmp(id.base.vendor_pn, "UF-INSTANT      ", 16)))
> 
> I would rather add a quirk member (bitfield) to the sfp structure and do
> something like this
> 
> if (!sfp->type->module_supported(&id) &&
>     !(sfp->quirks & SFP_QUIRK_BAD_PHYS_ID))
> 
> or maybe put this check into the module_supported method.

Sorry, definitely not. If you've ever looked at the SDHCI driver with
its multiple "quirks" bitfields, doing this is a recipe for creating
a very horrid hard to understand mess.

What you suggest just results in yet more complexity.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!