Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp10807007pxu; Wed, 30 Dec 2020 12:10:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwghvNtjuw9yvqHxJq6wyX6bYavar0kOD7b+4O/98QmMPvMyG4zCj1kfDGHR9k5JecQqQJr X-Received: by 2002:a17:907:16a7:: with SMTP id hc39mr24251095ejc.460.1609359029216; Wed, 30 Dec 2020 12:10:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609359029; cv=none; d=google.com; s=arc-20160816; b=RnpEACd37ArM0iA2uqTBDz9znEiDCWcR2WTvi9SC2SlOtq3cVvWhifUTA/zJV6K3KW M9pCkdn17xuAZkqnmxW1mZ0ZG59R+um/yKMVdVal2/de7WUv+D01fbNm61PKfPfo6IQT MK+9vAhWyVBEXzJbEJP6kNoZn/vpGeFO8AF1oqpVsbkcJrNIgpx270qquWvMAdL3Lt2E WL+Ji/n46Mf2hIEbWY/p/wlzLZqn0TzqfpSeRr7SPR6jISyEVwyOJgVzybK+QAIRC5yM FzpqrQtNXykl9fjNQcl2w03tabomxf3cnZ0yJN/lPtignBT2B9fJQAr/tT3IixOSOvfp 2OdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=pHfQY6iQBkFgk+jZK3r8AHEOu6YBi1c0Yv6IHMUISW8=; b=tiPWsApWBZ6m952CsoaUUdD98iIFmuPLEtmCCE22gcCRm3lg58M9XvVi/5siGi6p2+ X22XXoVjTgEbUZOasQySktjq8kHq4Zj0RprrEVnaa04MsWsnY6N4QQgzW4HBZ9b4NvW1 C0gYJeppuWr9f/zCl3tWXg9eA28IwilwBrHqWAbWY18BBVchLJd3yqIwnYkxRAIGWQ9p GOPk3LakbkvEwcB7KkRifhuzaY9u8qoBClUAYow7EN2QIPyYw/z+v0PFNF9kEDu5LbSu Y6Lst8DLMevz+v/yN2wHXY0YRChCSMI9ycMGepPQOJ4rcJvoHoxYzhWwE6mLeyEp0sOV byQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@jan-o-sch.net header.s=mail header.b=TvRlo3Lo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s20si19639832eji.61.2020.12.30.12.10.05; Wed, 30 Dec 2020 12:10:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@jan-o-sch.net header.s=mail header.b=TvRlo3Lo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726356AbgL3UG7 (ORCPT + 99 others); Wed, 30 Dec 2020 15:06:59 -0500 Received: from brockman.in8.de ([85.214.220.56]:36929 "EHLO mail.in8.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgL3UG7 (ORCPT ); Wed, 30 Dec 2020 15:06:59 -0500 Received: from [192.168.2.129] (p5dfd40c8.dip0.t-ipconnect.de [93.253.64.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.in8.de (Postfix) with ESMTPSA id C39196AC061; Wed, 30 Dec 2020 21:06:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jan-o-sch.net; s=mail; t=1609358777; bh=fTQGE4vI874rv3rcueCZ/e355kzmyTArOSPwuOI/enQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TvRlo3Lo4YDfQlRqseuz1QA45Dr0oJvSEaX6/PPokgm1rvNQMwBDxZkNI1oRcy7ZR dfWhIZvbaENUMkjicFYK+YcGSCUOOkzb6DWAzkcEbUkziAcg3tuebigFNIkLrEAVkr CfIUYTB0tDFV6U2QqOx9QE0vsy7cf6FDAELXOAU/ZIcM7GQ9RVFpu891tW0B9Qz+Ms sUdq07Xqro/yxEZC5I7ii05Vu9jkfi6c/KfFWF6WaLYYQe7ZkY7MRu1LUcV4BP7Wde 63IYxMW1d9xTTMcNaO7UjNd5FUvCGiHpZbzHiWZHa3Ibm/erVCGQKlWbQKCCotZqWe gZ6943vkLEBMQ== Subject: Re: [BUG] checkpatch: non-standard types cannot be declared after '}' To: Joe Perches , Andy Whitcroft Cc: linux-kernel@vger.kernel.org References: <58de45f3a0c7a4517110523edeccf19e6cec538c.camel@perches.com> From: Jan Schlien Autocrypt: addr=list.lkml@jan-o-sch.net; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tClZlcnNpb246IEdudVBHIHYy CgptUUlOQkZpbTJ3QUJFQUM0V0c1WnA4Mnh1amV4UlduWGJ5TkhCWUpuaDFnelA4bWZKdy82 RGR1ZVZOWVZMK2s5ClpWeG5NSk8xd1pBREJjRDE0QXZkYTR4VXU4Q0g3VjRyRmJZbWRrS1pu VCt3MXY4WUtxWjJ0dDMyRWx3eGkwV2cKM0VhMWlWZXRvUnBsNS9tRy9VV2JiNjB5eGJFbURW a282anplaFFWTlo3a241UEFlYWxGdkI2cXpDcmdJS2FrUgo5L3FDZzU1UEl6bXROejVVek40 K1JWSGFOMmlEQW5ZY0w1cWk5T1hxNER6T3QrbHF5ZzkrNll0UEtnT1lNS3F4ClZiWmtRRTdD dzhWVHVHQUlNK2o2YzNiMGRyTWlRczRiTklRdkhLOC8vbUZQZHRGa2RPTnpsNXRKbFRiVjB4 RnEKcjg5WkVCN3BLZ25OOThoTllUOGttczdzNkVqaitqd04ySExhQ0JScTJMSVBCNnhHS2lo bzhNTG95MUE4dDB5egp2UXUxNGkzdy9aT2pqbGplL1llcFUwcCtwZC8yMng3a1UybHFyaTdi THo5ZWY1YTJWZU5KNTBBWkRCNzhKVlNmCkhGVUs4WXFYUi9PV3Uyd1dINEZ1dGt5ZnhKcFg2 RE5UQm8vOFI3TnVaY25vcVU4ZXRyYlZhelMvbEg1RnhHanUKWE10bVBSWTJrYmM3VzlHSGl2 KzdlUTN0WDdDY3VUVytEZloyWDh6OUJmOTV3SzY1d1ZDTXBKNzQvR05EclVDMwpQZ2JISHU5 RDBpdGR1L1NQMSt5UElUalJnMG5RYkpXV0ZaZGd2Sk5oSjd2SmZ5VmVGTk1KMTBJYVp4QlQ4 VGxFClNNU1dlM1pTRXBmeXRZQ3VON2EwMXFtbGZZMWtpdmVYUG9rR1pRNk9hTXFJUXBWK1l1 NTdwNXk0ZlFBUkFRQUIKdEVaS1lXNGdVMk5vYkdsbGJpQW9kWE5sSUdadmNpQmhiR3dnYkc5 allXd2djR0Z5ZEhNZ2IyWWdkR2hwY3lCawpiMjFoYVc0cElEd3VRR3BoYmkxdkxYTmphQzV1 WlhRK2lRSkNCQk1CQWdBc0Foc2pCUWtKWmdHQUJ3c0pDQWNECkFnRUdGUWdDQ1FvTEJCWUNB d0VDSGdFQ0Y0QUZBbGltNHgwQ0dRRUFDZ2tRY3J1VENkMEt5VGtyZ3cvK09rYkUKL3FHRWNv dVQzSXVJN3Y4UHVTMVcvQ1JLbW5DSjNUWWN5TmJPMm5QZHB5Ui9QSGxYdjBIYmNXNkZ2UnJN OTQ3OQo2UmlpR3pVcHljejZxbUhWQ3JscG5mSzBBUmc2WFFDMkpML0V1RFBIVk9PVnhqR3Zh U0x3Q3c0RCtUQ25XazZjCmluaXpGYktybjNEd0VjK2NhNnhQY2hDVHhCcCtaMEdjbWVvZlFo Z0tqZVQ2N0tKKzdpTnVVdXpXQU53TldKeXoKeUNOTzhBbFIvTWw0RURFYkZ0SEpQbmxpUC9h d1pSOG5MY283b2dFb0pmQVhOWHJpeU9hZzJRRkFWNmczTTdnMgpmOGQ4N2JmOWJmMDdmbk5G RjJLTDdmU0VqL2hGN3ZNS1lZQ0VaeFY3TStLL0Z2TjdiS1lFaUdObkxkQUR5ZTE2Cll4N2JB VTlLVkJkWlpkRUJCVFNHV1lqUVdGTVdsNFdLRllZMit0amlSZDQ5ZnpFQVg2MzRXRTF0L1lP TGUvZEgKN21xNmp3eDFNcVFEWTlDaWZsdENMemh0TVpHQnpCbVJRWTdTS294bmFlbG0xWGRi eDY0aEhWQTRsa0xIOFMzRwo1bjJiejgyRExxeGdYbnorM0pzdkVQWVpKUDdqZk00alNHbTM2 RE95cEpVS3hUWHR1blFQQnQ4RDRReGU3L1FVCmgxbWJWMEU2VnNibXk4OGhKMnVRemdzcDBh cHp5ZjZiNm9XclBHc0d0UlNiT1BCSTVjQnA2dHorVXlNY2FwUFYKa1hBY0JVNnVrMHJrT3Q1 YjVCcUJDamtVR25OczlFQkxVZWRRSlVpb0tqWmpXeG1KUnJEVHJnK25CMXhlY0dRNgpHWFRC VG9HR3Rzb0ZSZTd6SXJ2V1VMVVNLZXp0MW5HVU1Ubnhlaks1QWcwRVdLYmJBQUVRQUtwMXdu MXBMUEwwCmZIbEhqQk1FQ0pLQVo5V0N1TU9DZHpnbko1R0tyWkRzbjhlTjhYajJHc0lVR3ZG dFBLM0JZelorUU5ha1NHbUMKYlpSOS8wWWhkTjlNby9vTEhHeTQ4dUMxa0xZWDRPYkdBbDhU blRlY1FKVFNwaXVZUmJnZVBBYnlIeHNXNVYzWgptbjhyeEhZa3ZpTWVZbXNIMENIanp6MjVD QW45YUtBaG5BNTlHQVV3M1JuelRyaEE2TkcxWXFacTZDUkNCYm8vCnBmWDR2dGRyVTVxWE5W ZXo4U0o0R2ZYL2dMbDFvTEJIWTlzdDF6RXdvRjhpbXZKY0VOWklTZzdlaHZ5NUVOTk0KV0k1 WEdvMHlFMUU4ampvTmRsU1NJYkJzL09JdmVUdVdsdE1aNll2eFlFQzMrWnUxcjVFV2J0cTVM QitvdC9LYQpUZHFmZlpwdjZkSjVjNVJHTW4zRlhldDBUbkJJbmdOZFU3VDh3SnN3cjFQazcw bXZrWEhSckxtTWUySmRtTmZXCkpLd1JsNEFwa2RjLzB1Yi9iaEZkTW9LaEoxU3l6ejQ0K3Nv VWREcVZPcDBLUS9hZHdPNDBLd0ljaEtScldCMHgKR29uZlNNUHNvd0lGRW01OVJkcE9seVdl bm9pZjd5cDJ4MVp5YXlHRWdHaGdQbzh0K3cwWExhMDhBVnJaa1czbApjM3dCUlM4a0g0Ziti Nnl6TWovUmdZd2VRVVd6b1pQVUdTWFNoYkZvT09TK2JiSXYwR0RGTHZ0cjVVc0U5VGx1CmJo MkkvS2xaWEI0R1FGYTBCbFpoeEhkU0oxMUtPL0htaDB6ZUxjUXlyb3JJTWxvUEQySHNkQjU3 UW5reVVGbG4KTkN5ek9uRVFYWXZuVnJyOUNYSlBHNWN2VlVHSlZ4ekhBQkVCQUFHSkFpVUVH QUVDQUE4RkFsaW0yd0FDR3d3RgpDUWxtQVlBQUNna1FjcnVUQ2QwS3lUbmlBdy8vYUI0R2V6 emZrOWZwQkRRMjNseDdMNElFNlozMXpFdE5JVUgxCmhRLzJTNy94NXBQVEhscklBYkRkL3Nj TnJLZTJuZ2Z1dHprWDlxRFJEczlQL0VSL0dGVVRTSkJhR0QvckRLNGQKWEhiUGxUeGR5T054 cG9xQTBROEdxekgzN0FWOGJXcDFDZVd4YlJvSGl0WTEwSVJyUkFDblVHSHl2bWpYVjhoNApY Sm9YL1dJWDlLaEpSSFVpMWViSmJaZmJsUnJSTTJ1dlVPREdqTm4wNmhmWmtEcWtKQzBJV3d2 cE1zV2ZmQUdTCmxOUUdKaXBzZit3UTdnWHI3UFl2ckQ3UkJWVlJ1VlUzM3JzS0orV0VIdUJq QXhva2ZzdXlpbDE0M05FWTAzWDcKNFZqdmNScWN5b0RNYzdVWlEyZUI5YjNyU2pBaUpLcGM2 Q2xKV3RuSC9hNjdIMkVKWDJkcGQ4L3Nnc3FhY1djUApxeG42c1UzTjdvU2h2Vk5zUU9XaHB3 ekV0dVVjeGMvdThpTnVUNEttY3pDOUZYTy9LYlpFRkZlMTN3THFrdEVvCmwxMlFUSUpoUmRE Y0FGaVFYK0ZxQkxGamV1dUI5ZjZVelU2MkQ2dkV5ekNCYlhodjlLMis5VDRYT2JnRTFicFYK b1M1eGtlcjdRei93TDkySmMybzZRdXYvUVlSSFVTQlBaaU5FY0lrZUFmNDI1TmFORFk1d3VP d3pRcEw1WmZPWApOb0VTTnpidG91aXFpTE42akkrT0RVVWZXR3lubHAvTnhEWmN5WkF3Mndo dURGYjNyY2xLNnBKaVpNSEcxNGI0CkswRUl2OXY2ejBkVm9TNFJIeXNMeXpmUlp2SkNxL24w TTFManI2dDVyRFk2VVk4T0pRVHpaODhJVnYwdEJGcHEKQW5Ta2xvMD0KPTBhMzAKLS0tLS1F TkQgUEdQIFBVQkxJQyBLRVkgQkxPQ0stLS0tLQo= Message-ID: <62817e31-d217-5641-f103-895843646524@jan-o-sch.net> Date: Wed, 30 Dec 2020 21:06:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <58de45f3a0c7a4517110523edeccf19e6cec538c.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.12.20 19:52, Joe Perches wrote: > On Wed, 2020-12-30 at 14:36 +0100, Jan Schlien wrote: >> Hi, >> >> I found some odd behavior of checkpatch.pl, which I'm currently using >> for own projects outside the kernel, but I verified that kernel patches >> can be affected as well. > > Hello Jan. > > I've had this patch locally for awhile that I believe fixes this > and another issue ($stat blocks can start with a close brace). > > I've been waiting for Andy to review it in case there's some other > parsing problem associated with it. Hello Joe, Thanks for digging that out promptly. Looks good to me and also fixes my issue. I cannot argue that I fully understand that function, so no review but you can add Tested-by: Jan Schlien if you like. Best, -Jan