Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 30 Dec 2020 20:52:15 +0000
To:     Krzysztof Kozlowski <krzk@kernel.org>
From:   Timon Baetz <timon.baetz@protonmail.com>
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Lee Jones <lee.jones@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Timon Baetz <timon.baetz@protonmail.com>
Reply-To: Timon Baetz <timon.baetz@protonmail.com>
Subject: [PATCH v6 3/8] power: supply: max8997_charger: Set CHARGER current limit
Message-ID: <20201230205139.1812366-3-timon.baetz@protonmail.com>
In-Reply-To: <20201230205139.1812366-1-timon.baetz@protonmail.com>
References: <20201230205139.1812366-1-timon.baetz@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Register for extcon notification and set charging current depending on
the detected cable type. Current values are taken from vendor kernel,
where most charger types end up setting 650mA [0].

Also enable and disable the CHARGER regulator based on extcon events.

[0] https://github.com/krzk/linux-vendor-backup/blob/samsung/galaxy-s2-epic=
-4g-touch-sph-d710-exynos4210-dump/drivers/misc/max8997-muic.c#L1675-L1678

Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
---
v6: dev_info() instead of dev_err().
v5: Use devm_regulator_get_optional(), dev_err() on failure.
    dev_err() on extcon_get_edev_by_phandle() failure.
v4: Make extcon and charger-supply optional.
v3: Split MFD change.
    return on regulator_set_current_limit() failure.
v2: Split DTS changes.
    Add missing include.
    Rename charger_data members.
    Disable regulator on regulator_set_current_limit() failure.
    Fix ret declaration.
    Remove unneeded variables.
    Don't dev_err() on deferral.
    Get regulator and extcon from DTS.
    Use devm_regulator_get().=20
    Fix indentation.

 drivers/power/supply/max8997_charger.c | 96 ++++++++++++++++++++++++++
 1 file changed, 96 insertions(+)

diff --git a/drivers/power/supply/max8997_charger.c b/drivers/power/supply/=
max8997_charger.c
index 1947af25879a..23df91ed2c72 100644
--- a/drivers/power/supply/max8997_charger.c
+++ b/drivers/power/supply/max8997_charger.c
@@ -6,12 +6,14 @@
 //  MyungJoo Ham <myungjoo.ham@samsung.com>
=20
 #include <linux/err.h>
+#include <linux/extcon.h>
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/platform_device.h>
 #include <linux/power_supply.h>
 #include <linux/mfd/max8997.h>
 #include <linux/mfd/max8997-private.h>
+#include <linux/regulator/consumer.h>
=20
 /* MAX8997_REG_STATUS4 */
 #define DCINOK_SHIFT=09=091
@@ -31,6 +33,10 @@ struct charger_data {
 =09struct device *dev;
 =09struct max8997_dev *iodev;
 =09struct power_supply *battery;
+=09struct regulator *reg;
+=09struct extcon_dev *edev;
+=09struct notifier_block extcon_nb;
+=09struct work_struct extcon_work;
 };
=20
 static enum power_supply_property max8997_battery_props[] =3D {
@@ -88,6 +94,67 @@ static int max8997_battery_get_property(struct power_sup=
ply *psy,
 =09return 0;
 }
=20
+static void max8997_battery_extcon_evt_stop_work(void *data)
+{
+=09struct charger_data *charger =3D data;
+
+=09cancel_work_sync(&charger->extcon_work);
+}
+
+static void max8997_battery_extcon_evt_worker(struct work_struct *work)
+{
+=09struct charger_data *charger =3D
+=09    container_of(work, struct charger_data, extcon_work);
+=09struct extcon_dev *edev =3D charger->edev;
+=09int current_limit;
+
+=09if (extcon_get_state(edev, EXTCON_CHG_USB_SDP) > 0) {
+=09=09dev_dbg(charger->dev, "USB SDP charger is connected\n");
+=09=09current_limit =3D 450000;
+=09} else if (extcon_get_state(edev, EXTCON_CHG_USB_DCP) > 0) {
+=09=09dev_dbg(charger->dev, "USB DCP charger is connected\n");
+=09=09current_limit =3D 650000;
+=09} else if (extcon_get_state(edev, EXTCON_CHG_USB_FAST) > 0) {
+=09=09dev_dbg(charger->dev, "USB FAST charger is connected\n");
+=09=09current_limit =3D 650000;
+=09} else if (extcon_get_state(edev, EXTCON_CHG_USB_SLOW) > 0) {
+=09=09dev_dbg(charger->dev, "USB SLOW charger is connected\n");
+=09=09current_limit =3D 650000;
+=09} else if (extcon_get_state(edev, EXTCON_CHG_USB_CDP) > 0) {
+=09=09dev_dbg(charger->dev, "USB CDP charger is connected\n");
+=09=09current_limit =3D 650000;
+=09} else {
+=09=09dev_dbg(charger->dev, "USB charger is diconnected\n");
+=09=09current_limit =3D -1;
+=09}
+
+=09if (current_limit > 0) {
+=09=09int ret =3D regulator_set_current_limit(charger->reg, current_limit,=
 current_limit);
+
+=09=09if (ret) {
+=09=09=09dev_err(charger->dev, "failed to set current limit: %d\n", ret);
+=09=09=09return;
+=09=09}
+=09=09ret =3D regulator_enable(charger->reg);
+=09=09if (ret)
+=09=09=09dev_err(charger->dev, "failed to enable regulator: %d\n", ret);
+=09} else {
+=09=09int ret  =3D regulator_disable(charger->reg);
+
+=09=09if (ret)
+=09=09=09dev_err(charger->dev, "failed to disable regulator: %d\n", ret);
+=09}
+}
+
+static int max8997_battery_extcon_evt(struct notifier_block *nb,
+=09=09=09=09unsigned long event, void *param)
+{
+=09struct charger_data *charger =3D
+=09=09container_of(nb, struct charger_data, extcon_nb);
+=09schedule_work(&charger->extcon_work);
+=09return NOTIFY_OK;
+}
+
 static const struct power_supply_desc max8997_battery_desc =3D {
 =09.name=09=09=3D "max8997_pmic",
 =09.type=09=09=3D POWER_SUPPLY_TYPE_BATTERY,
@@ -170,6 +237,35 @@ static int max8997_battery_probe(struct platform_devic=
e *pdev)
 =09=09return PTR_ERR(charger->battery);
 =09}
=20
+=09charger->reg =3D devm_regulator_get_optional(&pdev->dev, "charger");
+=09if (IS_ERR(charger->reg)) {
+=09=09if (PTR_ERR(charger->reg) =3D=3D -EPROBE_DEFER)
+=09=09=09return -EPROBE_DEFER;
+=09=09dev_info(&pdev->dev, "couldn't get charger regulator\n");
+=09}
+=09charger->edev =3D extcon_get_edev_by_phandle(&pdev->dev, 0);
+=09if (IS_ERR(charger->edev)) {
+=09=09if (PTR_ERR(charger->edev) =3D=3D -EPROBE_DEFER)
+=09=09=09return -EPROBE_DEFER;
+=09=09dev_info(charger->dev, "couldn't get extcon device\n");
+=09}
+
+=09if (!IS_ERR(charger->reg) && !IS_ERR(charger->edev)) {
+=09=09INIT_WORK(&charger->extcon_work, max8997_battery_extcon_evt_worker);
+=09=09ret =3D devm_add_action(&pdev->dev, max8997_battery_extcon_evt_stop_=
work, charger);
+=09=09if (ret) {
+=09=09=09dev_err(&pdev->dev, "failed to add extcon evt stop action: %d\n",=
 ret);
+=09=09=09return ret;
+=09=09}
+=09=09charger->extcon_nb.notifier_call =3D max8997_battery_extcon_evt;
+=09=09ret =3D devm_extcon_register_notifier_all(&pdev->dev, charger->edev,
+=09=09=09=09=09=09=09&charger->extcon_nb);
+=09=09if (ret) {
+=09=09=09dev_err(&pdev->dev, "failed to register extcon notifier\n");
+=09=09=09return ret;
+=09=09};
+=09}
+
 =09return 0;
 }
=20
--=20
2.25.1