Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp10864164pxu; Wed, 30 Dec 2020 14:04:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1jhycm5354u8oURRlwpufsyWUdLT1DMp3D1uO+zQJuflEYH2vrltw2E4Az51GmjWg7mgc X-Received: by 2002:a17:907:96a4:: with SMTP id hd36mr49295126ejc.393.1609365882741; Wed, 30 Dec 2020 14:04:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609365882; cv=none; d=google.com; s=arc-20160816; b=WtiHIMQtWnVkFLRGZq01+xNUS6oB77CBxCiwO7FjrBbzHj/EGQ7mFUGedSAyfIppLo f6nz3Bd7128It7iI64Oxx/NhSCK81tbDpBNSAW5aaSV4T3sIqOrrudH4p271BLIbjKSj y/AHCc/E8IncQ+Mgvlv8/Ejh7LEtZhuTEPOzSvoHAMsA0xhRWvdOaKYvmLNCP/74gkh8 qBxYsbIhPKNIDaXYBk0L4lYCP0U28IapScfVmODkMBp6JV7sNaJCgO/Pm2kQ0N2Hpgtw Vi9cTlGY/rM52p9sAoJctUjcyQO8vuhl2fbns1+FFcZQHf/dHZZTa0reHFAZ+gBOROGE JFkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5S7hiS0D1Nz3L10rmwrKZxQbbBpU1CmnpvlYUU/6LEU=; b=SrObwf7yNbrdfTqq9jDN1QX67kwu9YeCkcn1DG2FEpoTG9rs2XgAjg2yQqeaGNDC5N QjXGL1NodE2YMKQR9m2X6Bu0lyc3hWCSmOpTRqfT8fbVcI86HEdx+ANHJa41OeSM1IfP a74bAtqtdi7GMi3uabER6AvM0r9xbyQlr4mZFqnzYkUb67UCF/ZdmbYmUY3wwe0s+3iv l7XLCDoN4aLI6l2CSBWoWh+8+uPzoEzUuaIhOwOZl8uVoeiDp+qzRWYr7J4bWao6PML0 so9D6LOv9Cgd/dove8SfOmy3P7wyQLCVNSoidlw6Vg0ISU8hn43eSag52ufCjtA5fXb9 Sggg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Ru2Ww/Wh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga12si21620576ejb.522.2020.12.30.14.04.19; Wed, 30 Dec 2020 14:04:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Ru2Ww/Wh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726486AbgL3WBj (ORCPT + 99 others); Wed, 30 Dec 2020 17:01:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgL3WBj (ORCPT ); Wed, 30 Dec 2020 17:01:39 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA679C061573; Wed, 30 Dec 2020 14:00:58 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id y23so5917332wmi.1; Wed, 30 Dec 2020 14:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5S7hiS0D1Nz3L10rmwrKZxQbbBpU1CmnpvlYUU/6LEU=; b=Ru2Ww/WhliK61JsKemTEPiZMM1R5SNt/H3Soe5qqYF8/m/wlNro6WCA2lIECbrOFEf NGDoDylsZZlZSqsYRzWLAK1Y4Y+FVGJAY8O2tpiMBTtZx72k4VX10jphaMpw2nMEVRQ1 P5TdqwLoDRdFrxurvPJBYXY29RPJwDl5P2RwDqaxayHIeCuRKl94O6PyVnpO/YaOUDoe jCNilYYk6J9IV/HFHp9dk1vvuiAqnYKycJDasRi8wTQm/6jGp6qJxtYiC/vrhoeYEfLb wSdhObcKgqW7yLVW8N/nic92TXIjLu6VHhDOuQEj+D5BQO0IZ0fLW5o7JXgqh6K04oMX vxbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5S7hiS0D1Nz3L10rmwrKZxQbbBpU1CmnpvlYUU/6LEU=; b=p5N0/BX+/0TUd+5A62kP8v0kIOGj1TBumRLz1nH3SU6FNb0Zl+cEn692X0Y6Gg6X/C bk3YdTDoyR81oCGqzFAEAwxvj6vx8/syTaPXeDO5spcdK22KrSrHYAJAd5nx7xujKehj hs6/2klBbeUa+dLcYE7whs6gQ4b7Zz4m2CrqhtaJPz/wgZ92qPsgran/2+p9j3eNMkUj 573plqmra3qYUhGbU4Dis/9qcAoKACDaU46O2Z0Guko3mk+uVrhFflLdr/CWqETqE9l2 1UKyo7MW53ZD/f17iSswDk2MjFiTNfWAtSm0zpazJGwHVyvZgKX/aSHgXp1DUTVKr8pc 7zBA== X-Gm-Message-State: AOAM533UB6+lG82vBkEMf4zpkvtG6zzWaGI9cfLwcGy2/0khecAZ+zSl kTmeazIAeFjlxTfrEfJJlDzNkmJmw2PFvzosercFyLxQOGYm/w== X-Received: by 2002:a7b:c389:: with SMTP id s9mr8968721wmj.159.1609365657658; Wed, 30 Dec 2020 14:00:57 -0800 (PST) MIME-Version: 1.0 References: <1609312994-121032-1-git-send-email-abaci-bugfix@linux.alibaba.com> In-Reply-To: <1609312994-121032-1-git-send-email-abaci-bugfix@linux.alibaba.com> From: Lijun Pan Date: Wed, 30 Dec 2020 16:00:47 -0600 Message-ID: Subject: Re: [PATCH] ibmvnic: fix: NULL pointer dereference. To: YANG LI Cc: davem@davemloft.net, Jakub Kicinski , drt@linux.ibm.com, Lijun Pan , sukadev@linux.ibm.com, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2020 at 1:25 AM YANG LI wrote: > > The error is due to dereference a null pointer in function > reset_one_sub_crq_queue(): > > if (!scrq) { > netdev_dbg(adapter->netdev, > "Invalid scrq reset. irq (%d) or msgs(%p).\n", > scrq->irq, scrq->msgs); > return -EINVAL; > } > > If the expression is true, scrq must be a null pointer and cannot > dereference. > > Signed-off-by: YANG LI > Reported-by: Abaci > --- Acked-by: Lijun Pan