Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp11023979pxu; Wed, 30 Dec 2020 20:12:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJx2XI7eOwSmR+jY/saYlEgx4dQTBETt7uRRJ/lRmCBY4QD5NIIU4J+9toguiqtAG6026pA3 X-Received: by 2002:a17:906:971a:: with SMTP id k26mr52705346ejx.279.1609387965299; Wed, 30 Dec 2020 20:12:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609387965; cv=none; d=google.com; s=arc-20160816; b=kHUpttkqOkZyQXTNCNKnyaFtTcWNtexOTNUybiIuLXWyaMYsFXtahCUJQjqDxu5R5W xN+vOrEM6y0CZo+ielyzbEWlru/XSt/87l2gvel+nVQkbxBn/a+ToxBj3es6ThBZzqhM KV812dcpj18NT99gQW2VPXZ2iJFGe7v08+p6rtdgLABysWfYUu8JN3+N4T/VIhcDLA7j bxPJ6LAjkz80dTLoVxYiJL9LdL7lWgvpDpF7LCC1f0DuuGvyg3XN3Qlu/VlomvLeqjuo m+yCoTuiWcBywBiDDrw48ooCxl5CF24McMueSuHGG9NAQZ/Bvvjch7//1+O4Op1oa8uP 8lbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=rPdNh0if3lMMb/mFR3rxUMwxPRSaGl9LlXhQSgUIXps=; b=SHDxK/psNIYtafqhU5B2lm2MvjoiXmmnileQiK1oXUFIaPDXo4SLDz1q7ZASQJQ3lO tWBjVp1NVIvJDg6l/h/FCgyV19jNZgF7Oh0nFqupJQjaE0mGQf9+x5src10kwVYRoUQv GAaLVoAzDrxCKOJu0S6tk4mD8Y2TVejH2qFdJ5Unj4CH6zDdfXI9CDL7PI3620Y4Nzjf zLlxawAv1JJkGhPXinkpLDBaopFNZw+VrJFnLguObLGWJ48wIyADUb1rOZxshxke8ADl 3nbbDGfawYMWp0KgE6Y2tBG6cX/b8btVBok+oiA7CTOViRjQHyQ/LWU0CmdHZmdyuunX zztQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si23450474ejv.263.2020.12.30.20.12.22; Wed, 30 Dec 2020 20:12:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726348AbgLaELq (ORCPT + 99 others); Wed, 30 Dec 2020 23:11:46 -0500 Received: from regular1.263xmail.com ([211.150.70.195]:35578 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbgLaELq (ORCPT ); Wed, 30 Dec 2020 23:11:46 -0500 Received: from localhost (unknown [192.168.167.32]) by regular1.263xmail.com (Postfix) with ESMTP id F25971BED; Thu, 31 Dec 2020 12:05:50 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from localhost.localdomain (unknown [14.18.236.70]) by smtp.263.net (postfix) whith ESMTP id P25766T139972080289536S1609387543054560_; Thu, 31 Dec 2020 12:05:50 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: yili@winhong.com X-SENDER: yili@winhong.com X-LOGIN-NAME: yili@winhong.com X-FST-TO: joseph.qi@linux.alibaba.com X-SENDER-IP: 14.18.236.70 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: Yi Li To: joseph.qi@linux.alibaba.com Cc: mark@fasheh.com, yilikernel@gmail.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Yi Li Subject: [PATCH] ocfs2: Remove redundant conditional before iput Date: Thu, 31 Dec 2020 12:05:35 +0800 Message-Id: <20201231040535.4091761-1-yili@winhong.com> X-Mailer: git-send-email 2.25.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org iput handles NULL pointers gracefully, so there's no need to check the pointer before the call. Signed-off-by: Yi Li --- fs/ocfs2/super.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 2febc76e9de7..079f8826993e 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c @@ -973,8 +973,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb) * quota files */ dquot_disable(sb, type, DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED); - if (!inode) - continue; iput(inode); } } -- 2.25.3