Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp11485135pxu; Thu, 31 Dec 2020 10:36:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwVx1lj8dmiWi67W1kMyu3+Xk136ZoDJTUpzoDaRqcT+QioQAP8bjcSeM0YYX6yP8zKPCqV X-Received: by 2002:a50:f392:: with SMTP id g18mr3119244edm.306.1609439783993; Thu, 31 Dec 2020 10:36:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609439783; cv=none; d=google.com; s=arc-20160816; b=SGlnU6znaSFckLolEkdhycCx6OS0MYIcALOW09z0uT/E/QWBubgTiU0ZdLfGu9X+Hu MfrUvyrqlWBOlvA/feKR4EHu29sXNA2xcRpP1Oc7Vc/h0muiPxUFcN7ZvQxZGEJ3Hr7c CHZWa3FND24dzVDrklW2hf06vzgFPxGcsffYK3AzpYwAbuXzzo53RAPqjUXjKDps58xG /6kX6SXtE3lukU54t6jKaOtsWWCMl+8Hbm0l0anNAedinpnygHAyHHqT9CBxIpED5/D5 sxrzWmkvNjOHIHhmKTbg5ObXBZRYGq1hTHmCtH96yIWilhYvEfTwpOYnU9tNVPJ8axrk 8fjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ty0kCFeDhzpD1R54l+6ok2jqLiyYz/2CJd5lwQ+5enk=; b=JN/Kh4DxjbOJDyDlDRvPa/k3qw2Jen1IC0uiYrAZs/KATjqY72pQpfk4T2INpmu3jg /Az0SON+zcq4UtB3BSsT2m+1MmBeo9Y0hSXiaiwlv7A2tQZ27QA5AMH8oZv7I/Hs/ZkS d/6+WrP8QWKGYLKnsaLGbjaL6/rQj3i5TT3FxTEkxa/YGgCDqDfiwZBd4TL5tm9a7b5C KWEVGK9K2ywo1fgGHJD/3/HMcK1nYEKgGpAh1ijBinJhBhCAm00sFnqcx7Bqb+75gWnH V475iXb/xnSmQhXpYnNwyvxq0lesc08WgpiPEDRbLTWCxA+pAIVWEJOZNjgsgEJ4L2NV /qLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EBmsXDcW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o16si22950929eji.436.2020.12.31.10.35.51; Thu, 31 Dec 2020 10:36:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EBmsXDcW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbgLaS2m (ORCPT + 99 others); Thu, 31 Dec 2020 13:28:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:34482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726210AbgLaS2l (ORCPT ); Thu, 31 Dec 2020 13:28:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F11BE22473; Thu, 31 Dec 2020 18:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609439281; bh=6UolhkPVF5GeowbkR7qYVt8SbbBQkg0MBaZDTZ7XZkA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EBmsXDcW5jpoarQnWGcHDO9dhpOnFjE9QJKzKdGn/5aX5M02iiGQJ7EyPorGy0U2c LJgfnsggWvMWRMpJIMhx9XVeZnem+IbH4LQ4bCVLx+lQDsGt9+eRsxD8eHq1/Wuu+p pd4JAumiNyf0fwn+7cGlqpQPgfyHKtnFJEdiAjX313brJFRbq/riIB4OEgoaveEVDY /1MjiB/973spChUHDAs462vdAuXoV9CkJdSmM8HZHamRbVA/vC6HkWySja196PFGi4 yLXH4hDFZFQRl3y1eAAtEpU0SiCsnXrernUogMCK1zZ5PnkmbJ/Wg2Rg2AZsSd0apj Ow1I9JyZtZDCw== Received: by mail-ej1-f48.google.com with SMTP id g20so26228475ejb.1; Thu, 31 Dec 2020 10:28:00 -0800 (PST) X-Gm-Message-State: AOAM531itJTux8A+/SYa+zwtV0cR+tMxXJk9JCMD17WY3Y+JE+gEW/IH 1BiTABji5TE5hB/8DYctLiaFnk6eTwYhLrSHNw== X-Received: by 2002:a17:906:4146:: with SMTP id l6mr54869145ejk.341.1609439279516; Thu, 31 Dec 2020 10:27:59 -0800 (PST) MIME-Version: 1.0 References: <20201229113556.5dd4610c@xhacker.debian> In-Reply-To: <20201229113556.5dd4610c@xhacker.debian> From: Rob Herring Date: Thu, 31 Dec 2020 11:27:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] PCI: dwc: Fix MSI not work after resume To: Jisheng Zhang , Bjorn Helgaas Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , PCI , "linux-kernel@vger.kernel.org" , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 28, 2020 at 8:36 PM Jisheng Zhang wrote: > > After we move dw_pcie_msi_init() into core -- dw_pcie_host_init(), the > MSI stops working after resume. Because dw_pcie_host_init() is only > called once during probe. To fix this issue, we move dw_pcie_msi_init() > to dw_pcie_setup_rc(). > > Fixes: 59fbab1ae40e ("PCI: dwc: Move dw_pcie_msi_init() into core") > Signed-off-by: Jisheng Zhang > --- > > Since v1: > - rebased on 5.11-rc1 > - add Fixes tag > > drivers/pci/controller/dwc/pcie-designware-host.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring Bjorn, please pick up for 5.11. Rob