Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Jan 2021 09:18:48 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Gao Yan <gao.yanB@h3c.com>
Cc:     jirislaby@kernel.org, paulus@samba.org, davem@davemloft.net,
        kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2]net:ppp: remove disc_data_lock in ppp line discipline
Message-ID: <X+7a6OudZwupatGw@kroah.com>
References: <20210101033718.45198-1-gao.yanB@h3c.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210101033718.45198-1-gao.yanB@h3c.com>
Precedence: bulk

On Fri, Jan 01, 2021 at 11:37:18AM +0800, Gao Yan wrote:
> In tty layer, it provides tty->ldisc_sem to protect all tty_ldisc_ops
> including ppp_sync_ldisc. So I think tty->ldisc_sem can also
> protect tty->disc_data, and the disc_data_lock is not necessary.
> 
> Signed-off-by: Gao Yan <gao.yanB@h3c.com>
> ---
>  drivers/net/ppp/ppp_async.c   | 11 ++---------
>  drivers/net/ppp/ppp_synctty.c | 12 ++----------
>  2 files changed, 4 insertions(+), 19 deletions(-)

What changed from v1?

And how did you test this?  Why remove this lock, is it causing problems
somewhere for it to be here?

thanks,

greg k-h