Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND v2 2/2] Add support for Realtek RTL838x/RTL839x SoC
 SPI controllers
To:     Lukas Wunner <lukas@wunner.de>
Cc:     Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Birger Koblitz <mail@birger-koblitz.de>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20201229231904.2558916-1-bert@biot.com>
 <20201229231904.2558916-2-bert@biot.com> <20201231142319.GA28104@wunner.de>
From:   Bert Vermeulen <bert@biot.com>
Message-ID: <e9870e2f-d16c-3ed7-d672-7baa9a5e278c@biot.com>
Date:   Fri, 1 Jan 2021 12:27:41 +0100
MIME-Version: 1.0
In-Reply-To: <20201231142319.GA28104@wunner.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/31/20 3:23 PM, Lukas Wunner wrote:
> On Wed, Dec 30, 2020 at 12:19:04AM +0100, Bert Vermeulen wrote:
>> +static inline void wait_ready(struct rtspi *rtspi)
>> +{
>> +	while (!(readl(REG(RTL8380_SPI_SFCSR)) & RTL8380_SPI_SFCSR_RDY))
>> +		;
>> +}
> 
> I'd suggest calling cpu_relax() in the loop's body.
> 
> 
>> +	err = devm_spi_register_controller(&pdev->dev, ctrl);
> 
> Since you're invoking devm_spi_register_controller() on probe,
> the controller must not be unregistered explicitly on remove.
> So the ->remove hook can be dropped altogether:
> 
>> +static int realtek_spi_remove(struct platform_device *pdev)
>> +{
>> +	struct spi_controller *ctrl = platform_get_drvdata(pdev);
>> +
>> +	spi_unregister_controller(ctrl);
>> +
>> +	return 0;
>> +}
> [...]
>> +	.remove = realtek_spi_remove,
> 
> The ->probe hook otherwise LGTM.

Thanks Lukas, will fix those issues.


-- 
Bert Vermeulen
bert@biot.com