Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751789AbWIGPIL (ORCPT ); Thu, 7 Sep 2006 11:08:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751800AbWIGPIL (ORCPT ); Thu, 7 Sep 2006 11:08:11 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:3213 "EHLO e35.co.us.ibm.com") by vger.kernel.org with ESMTP id S1751789AbWIGPIH (ORCPT ); Thu, 7 Sep 2006 11:08:07 -0400 Subject: Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers From: Badari Pulavarty To: Jan Kara Cc: Andrew Morton , Anton Altaparmakov , sct@redhat.com, linux-fsdevel , lkml , ext4 In-Reply-To: <20060906172733.GC14345@atrey.karlin.mff.cuni.cz> References: <1157128342.30578.14.camel@dyn9047017100.beaverton.ibm.com> <20060901101801.7845bca2.akpm@osdl.org> <1157472702.23501.12.camel@dyn9047017100.beaverton.ibm.com> <20060906124719.GA11868@atrey.karlin.mff.cuni.cz> <1157555559.23501.25.camel@dyn9047017100.beaverton.ibm.com> <20060906153449.GC18281@atrey.karlin.mff.cuni.cz> <1157559545.23501.30.camel@dyn9047017100.beaverton.ibm.com> <20060906162723.GA14345@atrey.karlin.mff.cuni.cz> <1157563016.23501.39.camel@dyn9047017100.beaverton.ibm.com> <20060906172733.GC14345@atrey.karlin.mff.cuni.cz> Content-Type: text/plain Date: Thu, 07 Sep 2006 08:11:17 -0700 Message-Id: <1157641877.7725.13.camel@dyn9047017100.beaverton.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 28 > Ugh! Are you sure? For this path the buffer must be attached (only) to > the running transaction. But then how the commit code comes to it? > Somebody would have to even manage to refile the buffer from the > committing transaction to the running one while the buffer is in wbuf[]. > Could you check whether someone does __journal_refile_buffer() on your > marked buffers, please? Or whether we move buffer to BJ_Locked list in > the write_out_data: loop? Thanks. > > I added more debug in __journal_refile_buffer() to see if the marked buffers are getting refiled. I am able to reproduce the problem, but I don't see any debug including my original prints. (It looks as if none of my debug code exists) - its really confusing. I will keep looking and get back to you. I may try Andrew's buffer debug patch - if I get desperate. Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/