Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp12487965pxu; Sat, 2 Jan 2021 00:30:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyHyRiGc8nNOVdlLjB2Ck7ol8lbFkiauvfmLkG+XfSZdFYJw5KGS1S0ij9VtX69IKDff2VA X-Received: by 2002:a17:906:ceca:: with SMTP id si10mr58606900ejb.547.1609576212610; Sat, 02 Jan 2021 00:30:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609576212; cv=none; d=google.com; s=arc-20160816; b=zdVv9PvIU7r3OEob6UsV+ILJSGLrHiLUZgC8EMi4HPW75A99MZ117HU0fFJzjLq9/z dLK1T7AKuigl2t/V1y/hUD1L135aZ7kWxDJ/iXK5mCBLbkG/FzJ6h79cGVt95U9HOhjw DSFjyaczUHxeU+JC/U/q2rjZvrVN2QCKxdLChdAwH4JcNbQkUgKsz5sk3fjCDtxw0MxQ Hhv0wdiMDg113UBC1epBjglC14IQQOjZ0CkhTp25QME0N+mG9TQwA6dImvHxzqYH7DqG X7azShba3Sdiw1gUohVOsh9QmCoacJlx5S/++HXlAnQgiap7Q8mFAtWMxpqzIfqxrQVG dEsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=gcnL1Ua5lNpzSkm9hiyzqgXSvE/QGRQO7YpOSYrvuXQ=; b=d5cme3Zslo5vxnMbZnKNjc/wz2TSOy8zFvflmyNCO22AdKxWtvFsK69lrgE4Sgxaqa aG4W289mtL4WbGP+9LgNbVA/Oe3fphly+JZd0HR2oFYdGPjAVOpUNV+nfogPxA8bfRsd X6bGtWEv4oJYdFDjBGCWbv9ialhKAetMX4g6RdcPAbdVSUS74sEeISWqG/kKVJCQdZ7X KoHU3YQ2nCbxqiZaMkbGLKW6gGnlA65AyammwV+gZFdoW0nSNM1UTvMxOgjsE58J7gpJ KVUlWXmE1lSAFqU4NseG7kGcjkwV+RifKeHZWDKFpCAKwiRn686X+7W4vT1YNSGtlkmn pZVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rv19si11465116ejb.262.2021.01.02.00.29.35; Sat, 02 Jan 2021 00:30:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbhABI1l (ORCPT + 99 others); Sat, 2 Jan 2021 03:27:41 -0500 Received: from spam.zju.edu.cn ([61.164.42.155]:16726 "EHLO zju.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725320AbhABI1l (ORCPT ); Sat, 2 Jan 2021 03:27:41 -0500 Received: from localhost.localdomain (unknown [10.192.85.18]) by mail-app4 (Coremail) with SMTP id cS_KCgBnGAhALvBfkzdHAA--.6633S4; Sat, 02 Jan 2021 16:26:44 +0800 (CST) From: Dinghao Liu To: dinghao.liu@zju.edu.cn, kjlu@umn.edu Cc: Mauro Carvalho Chehab , Michel Ludwig , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: tm6000: Fix memleak in tm6000_start_stream Date: Sat, 2 Jan 2021 16:26:37 +0800 Message-Id: <20210102082639.15304-1-dinghao.liu@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: cS_KCgBnGAhALvBfkzdHAA--.6633S4 X-Coremail-Antispam: 1UD129KBjvdXoWrKw1xtry7Cw13Jw1xAw1rCrg_yoWDJwcE9F 95Wrs7Ww1UWr15tr1xtwn2yryqkFs7Zry8WFWqy34fGFWjkFyaqrWkWF4fGrnxCFW0qFWD CFy5ZF1xAwnI9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbc8Fc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AK wVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20x vE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E 87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c 8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_ Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwI xGrwACjI8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vIr41l42xK82IY6x8ErcxF aVAv8VW8uw4UJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr 4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxG rwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8Jw CI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY 6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUoOJ5UUUUU X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAg0IBlZdtRuRfAAXse Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When usb_clear_halt() fails, dvb->bulk_urb->transfer_buffer and dvb->bulk_urb should be freed just like when usb_submit_urb() fails. Fixes: 3169c9b26fffa ("V4L/DVB (12788): tm6000: Add initial DVB-T support") Signed-off-by: Dinghao Liu --- drivers/media/usb/tm6000/tm6000-dvb.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/usb/tm6000/tm6000-dvb.c b/drivers/media/usb/tm6000/tm6000-dvb.c index 19c90fa9e443..293a460f4616 100644 --- a/drivers/media/usb/tm6000/tm6000-dvb.c +++ b/drivers/media/usb/tm6000/tm6000-dvb.c @@ -141,6 +141,10 @@ static int tm6000_start_stream(struct tm6000_core *dev) if (ret < 0) { printk(KERN_ERR "tm6000: error %i in %s during pipe reset\n", ret, __func__); + + kfree(dvb->bulk_urb->transfer_buffer); + usb_free_urb(dvb->bulk_urb); + dvb->bulk_urb = NULL; return ret; } else printk(KERN_ERR "tm6000: pipe reset\n"); -- 2.17.1