Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/3] vhost/vsock: support for SOCK_SEQPACKET socket.
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     Stefan Hajnoczi <stefanha@redhat.com>,
        Stefano Garzarella <sgarzare@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20201229110634.275024-1-arseny.krasnov@kaspersky.com>
 <20201230155410-mutt-send-email-mst@kernel.org>
 <20201230155742-mutt-send-email-mst@kernel.org>
From:   Arseny Krasnov <arseny.krasnov@kaspersky.com>
Message-ID: <ff5993ea-7001-78fa-ec2f-dda1ae606b36@kaspersky.com>
Date:   Sat, 2 Jan 2021 13:12:13 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201230155742-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering
 rules found
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 02.01.2021 4:50:00
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering
 rules found
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
X-KLMS-Rule-ID: 52
X-KLMS-Message-Action: clean
X-KLMS-AntiSpam-Status: not scanned, disabled by settings
X-KLMS-AntiSpam-Interceptor-Info: not scanned
X-KLMS-AntiPhishing: Clean, bases: 2021/01/02 09:25:00
X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2021/01/01 22:24:00 #15996345
X-KLMS-AntiVirus-Status: Clean, skipped
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> oh this was not threaded correctly so I did not see rest of
> patches. ignore this pls will respond there.

Sorry, i'll resend whole patchset ASAP in one thread.

On 30.12.2020 23:58, Michael S. Tsirkin wrote:
> On Wed, Dec 30, 2020 at 03:56:03PM -0500, Michael S. Tsirkin wrote:
>> On Tue, Dec 29, 2020 at 02:06:33PM +0300, Arseny Krasnov wrote:
>>> 	This patch simply adds transport ops and removes
>>> ignore of non-stream type of packets.
>>>
>>> Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
>> How is this supposed to work? virtio vsock at the moment
>> has byte level end to end credit accounting at the
>> protocol level. I suspect some protocol changes involving
>> more than this tweak would
>> be needed to properly support anything that isn't a stream.
>
> oh this was not threaded correctly so I did not see rest of
> patches. ignore this pls will respond there.
>
>>> ---
>>>  drivers/vhost/vsock.c | 6 ++++--
>>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
>>> index a483cec31d5c..4a36ef1c52d0 100644
>>> --- a/drivers/vhost/vsock.c
>>> +++ b/drivers/vhost/vsock.c
>>> @@ -346,8 +346,7 @@ vhost_vsock_alloc_pkt(struct vhost_virtqueue *vq,
>>>  		return NULL;
>>>  	}
>>>  
>>> -	if (le16_to_cpu(pkt->hdr.type) == VIRTIO_VSOCK_TYPE_STREAM)
>>> -		pkt->len = le32_to_cpu(pkt->hdr.len);
>>> +	pkt->len = le32_to_cpu(pkt->hdr.len);
>>>  
>>>  	/* No payload */
>>>  	if (!pkt->len)
>>> @@ -416,6 +415,9 @@ static struct virtio_transport vhost_transport = {
>>>  		.stream_is_active         = virtio_transport_stream_is_active,
>>>  		.stream_allow             = virtio_transport_stream_allow,
>>>  
>>> +		.seqpacket_seq_send_len	  = virtio_transport_seqpacket_seq_send_len,
>>> +		.seqpacket_seq_get_len	  = virtio_transport_seqpacket_seq_get_len,
>>> +
>>>  		.notify_poll_in           = virtio_transport_notify_poll_in,
>>>  		.notify_poll_out          = virtio_transport_notify_poll_out,
>>>  		.notify_recv_init         = virtio_transport_notify_recv_init,
>>> -- 
>>> 2.25.1
>