Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp12938386pxu; Sat, 2 Jan 2021 18:15:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGexco1ghpZgPVQpRc/KeEBm7Tnzmnf9bW9bI35+Ck0Waoj72Md/fl7TRjEUCx9i2isvci X-Received: by 2002:aa7:c3d3:: with SMTP id l19mr67049799edr.366.1609640100765; Sat, 02 Jan 2021 18:15:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609640100; cv=none; d=google.com; s=arc-20160816; b=ZrDkiFoBbwH/V3IGGPzHpF4CLPQMupCFTfRAD0Dkyl15ZgvDcdO1qwfqQvkS96uN53 qCP32qro1vnbphCmjUjraJ5Zsm3ntzZJGqK+hj4NG02cL4p7GQhbLM9eCQUrnPz1OKFL Y7ftkfj5ADPbZYxqtiB/m1w+l8eXUHuUTZ1rwyWDd3ldKUQE//1gypA/1s/1QiCoyGSY gIzYmov9RbLpoWudvQZINVD4G0Q1RCwGw15KjiSLOZTnDKZE4XWpzgtJCduqIw6YeuVj 7HtBNOQJI6LQggwKkd0lWyrEe7jJOeagE92T7V8r3xuY7e54u7qQ2MKv3/htodIeESIu f/+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=mdMzQazYuuqK+Mo77p87BaWfToOrxP/Uh7GEHhqBbnA=; b=YMQLZcBHb8JL0boPjK8y7dSuzhTIGjzbvaYW1swMbIeQQS6mlaNQL1yPb91Ba5wP1a G8dtIM/KzZ7fd7aOuWJi22xy43oVJJ72xomHenJMlFvKhFyDza3njuiQW7csrnsOmCHJ 9QhqHM8RmFQJNwBOUjPQ/0L+RIYFRETrxuMZlZOW7L+qbt9B1C8yrAtN8x7dJUuVp5Np cPMz6FU9IBddDx+suyQnSj5P8QyCRwyUDIYemrBhiL3P05NVLwgnlfNFDuPkVmwQ3fVR 6+0GGSRe6Y9WHRrTDQXBM23BohuNbW0RCamiaCsTA9EeKJZJSgA/Kwd/y6GfooM6j2Tb JIyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=G6d3qNAT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lx6si27153996ejb.550.2021.01.02.18.14.37; Sat, 02 Jan 2021 18:15:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=G6d3qNAT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbhACCNO (ORCPT + 99 others); Sat, 2 Jan 2021 21:13:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbhACCNO (ORCPT ); Sat, 2 Jan 2021 21:13:14 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63DC6C061573; Sat, 2 Jan 2021 18:12:33 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id w1so32266427ejf.11; Sat, 02 Jan 2021 18:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mdMzQazYuuqK+Mo77p87BaWfToOrxP/Uh7GEHhqBbnA=; b=G6d3qNATHB3eF3CsfNBka8AtiMvfx5Q4/GBB9HFwCHs5K1Od6c4qeGzcWmyzti1HsY E7o2hU/rrz3tOdKYMQ/i22lgwdNkXB09zAigcZpa/xnSiJdznqzD4yxFLTpiHaxcsdL4 UeIUg5i6OAvyPYLmDFanaAy4sqKEFSixyBi+bWkeb4vAmn7QJVS1RcUTYewWlonvhS2b xcfb6jqDM/9EK0iVpUZV7T6qZ1SS1zWztBrCYNL43/CFymXF09Bmj9ZGNAejCG7dfIG2 4pYqqq6gPtresYOTn/LCs7YGxH8YQTnamwZ6WJndpADxx7nazjPsGB5J52G1oLBLXRoS No7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mdMzQazYuuqK+Mo77p87BaWfToOrxP/Uh7GEHhqBbnA=; b=PwwYqkVHJ163UElOhkESvCL6nvH91393aZyBEbugNMaVKxbWcFXTIahuJGg5XYR9oH Xp6HTLjU0Qb11Jou+cK1sEjExfT48wTbodkQFSBB8t6MQ+pqEqKdAtXaZ0K72KqBwbeW wj3jBSsuMXeVnJFAmyq2XUVcWmcN3vNc7UKpuOBwdVyVCVLNjOfWgHHGhJwxdfF/g4NO tBS/ykpEX81uM9X6NVn+HbyIbdNWDrirnRJozjI8sqp/AK+Mo9FqqdIEaiyrHhGRcJBF rWQvV4jxb7BU+ifu6GHhVjGY569z9Ec1TbXgxpmUpYKWOQuqVWHoRNtMBaF0GdZOV78/ EmPA== X-Gm-Message-State: AOAM533h5m4hekfqpvSxnk45KY9LjOdG9Fj179RPmPtWOi9gSvW/rKeB GKoxkoqvMyCgkghowWlO0U9DIiiN912+PE+PlVJmLfI5 X-Received: by 2002:a17:906:4050:: with SMTP id y16mr60198536ejj.537.1609639952205; Sat, 02 Jan 2021 18:12:32 -0800 (PST) MIME-Version: 1.0 References: <20210103012544.3259029-1-martin.blumenstingl@googlemail.com> <20210103012544.3259029-2-martin.blumenstingl@googlemail.com> In-Reply-To: From: Martin Blumenstingl Date: Sun, 3 Jan 2021 03:12:21 +0100 Message-ID: Subject: Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs To: Andrew Lunn Cc: Hauke Mehrtens , netdev@vger.kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Sun, Jan 3, 2021 at 3:09 AM Andrew Lunn wrote: > > On Sun, Jan 03, 2021 at 02:25:43AM +0100, Martin Blumenstingl wrote: > > Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. > > Without this the PHY link is detected properly and ethtool statistics > > for TX are increasing but there's no RX traffic coming in. > > > > Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > > Cc: stable@vger.kernel.org > > Hi Martin > > No need to Cc: stable. David or Jakub will handle the backport to > stable. You should however set the subject to [PATCH net 1/2] and > base the patches on the net tree, not net-next. do you recommend re-sending these patches and changing the subject? the lantiq_gswip.c driver is identical in -net and -net-next and so the patch will apply fine in both cases Best regards, Martin