Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <16871.1609618487@turing-police>
In-Reply-To: <16871.1609618487@turing-police>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun, 3 Jan 2021 15:30:30 +0900
Message-ID: <CAK7LNAQU61eccDfh_jX_cnZHnyxfbfgBGu1845QM8XbBTJPnsw@mail.gmail.com>
Subject: Re: Kconfig, DEFAULT_NETSCH, and shooting yourself in the foot..
To:     =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= <valdis.kletnieks@vt.edu>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        "David S. Miller" <davem@davemloft.net>,
        Networking <netdev@vger.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Jan 3, 2021 at 5:14 AM Valdis Kl=C4=93tnieks <valdis.kletnieks@vt.e=
du> wrote:
>
> Consider the following own goal I just discovered I scored:
>
> [~] zgrep -i fq_codel /proc/config.gz
> CONFIG_NET_SCH_FQ_CODEL=3Dm
> CONFIG_DEFAULT_FQ_CODEL=3Dy
> CONFIG_DEFAULT_NET_SCH=3D"fq_codel"
>
> Obviously, fq_codel didn't get set as the default, because that happens
> before the module gets loaded (which may never happen if the sysadmin
> thinks the DEFAULT_NET_SCH already made it happen)
>
> Whoops. My bad, probably - but....
>
> The deeper question, part 1:
>
> There's this chunk in net/sched/Kconfig:
>
> config DEFAULT_NET_SCH
>         string
>         default "pfifo_fast" if DEFAULT_PFIFO_FAST
>         default "fq" if DEFAULT_FQ
>         default "fq_codel" if DEFAULT_FQ_CODEL
>         default "fq_pie" if DEFAULT_FQ_PIE
>         default "sfq" if DEFAULT_SFQ
>         default "pfifo_fast"
> endif
>
> (And a similar chunk right above it with a similar issue)
>
> Should those be "if (foo=3Dy)" so =3Dm can't be chosen? (I'll be
> happy to write the patch if that's what we want)
>
> Deeper question, part 2:
>
> Should there be a way in the Kconfig language to ensure that
> these two chunks can't accidentally get out of sync?  There's other
> places in the kernel where similar issues arise - a few days ago I was
> chasing a CPU governor issue where it looked like it was possible
> to set a default that was a module and thus possibly not actually loaded.
>


If there is a restriction where a modular discipline cannot be the default,
I think you can add 'depends on FOO =3D y'.


For example,


choice
           prompt "Default"

           config DEFAULT_FOO
                  bool "Use foo for default"
                  depends on FOO =3D y

           config DEFAULT_BAR
                  bool "Use bar for default"
                  depends on BAR =3D y

           config DEFAULT_FALLBACK
                  bool "fallback when nothing else is builtin"

endchoice


--=20
Best Regards
Masahiro Yamada