Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp13624791pxu; Sun, 3 Jan 2021 23:01:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqCVmBq+MhLi+1B8PQK6lHsJKrd72cg8nFFKwfpFkrKn8vaOzdjNCsJ4u2be5pDRYxW3zD X-Received: by 2002:a05:6402:c4:: with SMTP id i4mr69016289edu.152.1609743716379; Sun, 03 Jan 2021 23:01:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609743716; cv=none; d=google.com; s=arc-20160816; b=ikEsFMDS0T8Gs2Dy2tXVhTILUNVSOHWbFa7Vxt/izTxo88etIz2Il/c+3hjj/MdMXQ rgK0gOuU+3dXQupHKxJoIrAKN83mc7iNb2olCTzJROlftprif5ETtbEnwoIb4AOBEKzp CAXRLO1FXnNcnQd+a7mOxr+r8W1VhPmFikoQOEE4G5BQDHo47ccO3kC0/EPbp5rwjAXu gYeiUasT3b6NsoPIkus7x5NCUtqJqETQnIzjEfnzM9rdsECSl4fUtEapaRqkkL7J584Z 6UOIUwZ4K7m6ciHv+DA7O458WerOYRB19jA0FkXYWvHI7tQtA4kSdCgzCd1Kvki23k9J BkGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5JtJSGoa5TRfuuBNc87icAYiWh/b5eXjv2GjseWaFBo=; b=xxcVAcZ+xMo5LqX6wXJdr/yVCHaqn7qP/fjP/kAWTm7J0QXnJOCe48dxTCSVgoQdAm 7DAZ6++z8nD8A1K/vQVz0+NG1fs1f84RiItEavOLac00B0j2m5FGZHz2VZ/4bTqlKlP9 yhqdDxoljP3lKfkNRcwCcTE8Aeo0jYge9PiNWnRJ8cCWSrFdeV6ub/Jd0brNnUxKsU0J XdyXLmJ0+bwcJNp1f+bJSeBK3ICLLnhi7p7OxW9gPtpcebpTZ4m1ka89+nhTouQLRozt 2n2iGmtONaMkzyt89v7LqYYLKVE5K+YWQfHCiIfk12fX5II0LpCD1E8YiXAzUqqcyX1/ IctA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SlNZHHVH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg28si31610830edb.167.2021.01.03.23.01.33; Sun, 03 Jan 2021 23:01:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SlNZHHVH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbhADG5y (ORCPT + 99 others); Mon, 4 Jan 2021 01:57:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52361 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728325AbhADG5v (ORCPT ); Mon, 4 Jan 2021 01:57:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609743385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5JtJSGoa5TRfuuBNc87icAYiWh/b5eXjv2GjseWaFBo=; b=SlNZHHVHQaaOs7nyWymqULNuzQWhaj1PMUUpUWqSZn4q8EA+sOFXsS7F/XAg2Yfc7Jilch LWFXqG1A6DhFou4oMBZc6neE8rvn59voL4nHMUp0aUvfEhxrrhkg8aXDvoo+9FNT1n/IAk 6MHt453q2x7NGrKxnVdwD/RZ9ovIWD0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-kNuBByiiNQe2UM0P1e_Z7Q-1; Mon, 04 Jan 2021 01:56:21 -0500 X-MC-Unique: kNuBByiiNQe2UM0P1e_Z7Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 86538107ACE3; Mon, 4 Jan 2021 06:56:20 +0000 (UTC) Received: from jason-ThinkPad-X1-Carbon-6th.redhat.com (ovpn-13-91.pek2.redhat.com [10.72.13.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id D72D51002388; Mon, 4 Jan 2021 06:56:17 +0000 (UTC) From: Jason Wang To: mst@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: shahafs@mellanox.com, lulu@redhat.com, sgarzare@redhat.com, rdunlap@infradead.org, Jason Wang Subject: [PATCH V3 18/19] virtio_vdpa: don't warn when fail to disable vq Date: Mon, 4 Jan 2021 14:55:02 +0800 Message-Id: <20210104065503.199631-19-jasowang@redhat.com> In-Reply-To: <20210104065503.199631-1-jasowang@redhat.com> References: <20210104065503.199631-1-jasowang@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no guarantee that the device can disable a specific virtqueue through set_vq_ready(). One example is the modern virtio-pci device. So this patch removes the warning. Signed-off-by: Jason Wang --- drivers/virtio/virtio_vdpa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index 4a9ddb44b2a7..e28acf482e0c 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_vdpa.c @@ -225,9 +225,8 @@ static void virtio_vdpa_del_vq(struct virtqueue *vq) list_del(&info->node); spin_unlock_irqrestore(&vd_dev->lock, flags); - /* Select and deactivate the queue */ + /* Select and deactivate the queue (best effort) */ ops->set_vq_ready(vdpa, index, 0); - WARN_ON(ops->get_vq_ready(vdpa, index)); vring_del_virtqueue(vq); -- 2.25.1