Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] microblaze: do not select TRACING_SUPPORT directly
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kernel@vger.kernel.org
References: <20201223152947.698744-1-masahiroy@kernel.org>
From:   Michal Simek <monstr@monstr.eu>
Message-ID: <bf6e0579-c403-8e82-9672-eb0f55c042c2@monstr.eu>
Date:   Mon, 4 Jan 2021 10:43:42 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20201223152947.698744-1-masahiroy@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 23. 12. 20 16:29, Masahiro Yamada wrote:
> Microblaze is the only architecture that selects TRACING_SUPPORT.
> 
> In my understanding, it is computed by kernel/trace/Kconfig:
> 
>   config TRACING_SUPPORT
>           bool
>           depends on TRACE_IRQFLAGS_SUPPORT
>           depends on STACKTRACE_SUPPORT
>           default y
> 
> Microblaze enables both TRACE_IRQFLAGS_SUPPORT and STACKTRACE_SUPPORT,
> so there is no change in the resulted configuration.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  arch/microblaze/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
> index a0e0c43a2852..acd6d0e68089 100644
> --- a/arch/microblaze/Kconfig
> +++ b/arch/microblaze/Kconfig
> @@ -39,7 +39,6 @@ config MICROBLAZE
>  	select OF_EARLY_FLATTREE
>  	select PCI_DOMAINS_GENERIC if PCI
>  	select PCI_SYSCALL if PCI
> -	select TRACING_SUPPORT
>  	select VIRT_TO_BUS
>  	select CPU_NO_EFFICIENT_FFS
>  	select MMU_GATHER_NO_RANGE
> 

make sense.

Applied.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs