Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 Jan 2021 10:04:58 +0000
From:   Stefan Hajnoczi <stefanha@gmail.com>
To:     Jason Wang <jasowang@redhat.com>
Cc:     mst@redhat.com, kvm@vger.kernel.org, lulu@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, eperezma@redhat.com,
        stefanha@redhat.com, eli@mellanox.com, lingshan.zhu@intel.com,
        rob.miller@broadcom.com
Subject: Re: [PATCH 06/21] vdpa: introduce virtqueue groups
Message-ID: <20210104100458.GC342399@stefanha-x1.localdomain>
References: <20201216064818.48239-1-jasowang@redhat.com>
 <20201216064818.48239-7-jasowang@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Md/poaVZ8hnGTzuv"
Content-Disposition: inline
In-Reply-To: <20201216064818.48239-7-jasowang@redhat.com>
Precedence: bulk


--Md/poaVZ8hnGTzuv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 16, 2020 at 02:48:03PM +0800, Jason Wang wrote:
> This patch introduces virtqueue groups to vDPA device. The virtqueue
> group is the minimal set of virtqueues that must share an address
> space. And the adddress space identifier could only be attached to
> a specific virtqueue group.
>=20
> A new mandated bus operation is introduced to get the virtqueue group
> ID for a specific virtqueue.
>=20
> All the vDPA device drivers were converted to simply support a single
> virtqueue group.
>=20
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  drivers/vdpa/ifcvf/ifcvf_main.c   |  9 ++++++++-
>  drivers/vdpa/mlx5/net/mlx5_vnet.c |  8 +++++++-
>  drivers/vdpa/vdpa.c               |  4 +++-
>  drivers/vdpa/vdpa_sim/vdpa_sim.c  | 11 ++++++++++-
>  include/linux/vdpa.h              | 12 +++++++++---
>  5 files changed, 37 insertions(+), 7 deletions(-)

Maybe consider calling it iotlb_group or iommu_group so the purpose of
the group is clear?

--Md/poaVZ8hnGTzuv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl/y6EoACgkQnKSrs4Gr
c8iKNwgAtnS7PgEL7jT2JkaKAXLejyXKO8IW8xfLeTqNpJCmwkwbyzsQjH83riBW
TFaz9i//mTuWeJjzc9ZPWSkeDGQ30KdUG+keqyrr4IBcu2g7YO58mAqf8DL/b/Vf
EkX+sXimegTguYioYzT5zbgApNPlo5RPJWS0UTInQ8n2+gzXKmBmhyI9EXchVNqz
MZDTWzKqZ6urkT5JZlOIlMa1Mw/Xr+yRQpVIBYuZe3GEdwM5gfn6ElhAyrT8qhO/
ssFCNPzcSuJl+2MhxDVM3uyaadUQhr63o4BzNSSyr2Gk4i+nepfTCe0pXukbrnGs
wWqtRMGsRbjl811BZJwNtdVCqu/lsw==
=J7Jn
-----END PGP SIGNATURE-----

--Md/poaVZ8hnGTzuv--