Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 00/13] iommu/amd: Add Generic IO Page Table Framework
 Support
To:     linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Cc:     joro@8bytes.org, will@kernel.org
References: <20201215073705.123786-1-suravee.suthikulpanit@amd.com>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Message-ID: <f9674d19-74bf-1209-5d9d-1517d3ad27f7@amd.com>
Date:   Mon, 4 Jan 2021 18:01:37 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.6.0
In-Reply-To: <20201215073705.123786-1-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from Suravees-MacBook-Pro.local (2001:fb1:e3:c9d4:89cc:2e93:10a4:9f87) by KU1PR03CA0007.apcprd03.prod.outlook.com (2603:1096:802:18::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.4 via Frontend Transport; Mon, 4 Jan 2021 11:01:46 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 339399e8-1295-4eef-62e9-08d8b0a021f1
X-MS-TrafficTypeDiagnostic: BYAPR12MB3605:
X-Microsoft-Antispam-PRVS: <BYAPR12MB3605948BA7539381B6AF1FEAF3D20@BYAPR12MB3605.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OMBSc0Sj8Uny3ZqC0cSZxpabzkBLQ9fQ44zqC6lbnW84BTMTIeSKrNp9hHVhGVhFlBNGuGXLcNRQBNWxa+0pH8PPCAa/M84kHctaJoHOHEWpsx9T0Oq1UKE8HsWyEC5DZZSQNhndhG7MDG8deSkrC5seh4Bez0JL8ZVqA8xGDa2RdFfFKFJC6wiHtajFvUHbk3smhlpVhhoS/XL0g0v4QLHa4NQNimeY0PCXXdU00plrLyVTp2RRwvw+gw+WSgnZKnia9lDmOSTs8TUAWiD2SeDrrnSPirxnQOuY/6MeqCFZtqubduf9pCDewIWmYhqDFq4jy5YmXUM2iLSqwghwpR80GHwJ4O1toROdQdMnX/2emOWB+eNALk6fa8ILlIC4TG8aICjDXFG/TisNpVyGxz9qlXuPpRIl7U8rMvZLSC4W/4gujURIYvaahslGN4JDIiV6bOLfpgoNpkyEyyE/tLgGmH7Lc0bdyE2xsCfgJJLkRWa22c4BQd7XfHu0xCZaLenj8c0Yxz63kq4Mcj8ivQ2CFS0oly2g/oNifWkTuFVGcFu8alXznQCsGYlXOW/s68hVeF5eEJ97LEpu+07QBg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB4597.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(39860400002)(366004)(346002)(396003)(6486002)(6512007)(31696002)(31686004)(316002)(66946007)(4326008)(86362001)(52116002)(66476007)(66556008)(5660300002)(53546011)(6506007)(44832011)(2616005)(83380400001)(478600001)(36756003)(8936002)(6666004)(186003)(16526019)(8676002)(2906002)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QXJaM1RSVUl4TkxYRmFEczFrYXpkMVBLWnZVcUw5aDRPKzhickJOeFJreXlY?=
 =?utf-8?B?bzVGV1BqVXl3TkQrajVEeTJkWjVLRnpQY1V2WlNGbjFqN0UreGtQd2paSllU?=
 =?utf-8?B?ZVU2ckdZa3RybktIRWswNlY3SXROQnRvZHlCODJwQ3RjNzNxanRKT1cwWXNX?=
 =?utf-8?B?aVVNaEFHUURZRkJzUnFsaklCN0xjTmsyK2VqWVdqK0pUc2JGRGsrTXBmdlRG?=
 =?utf-8?B?a2dqVmdFV0tSdE54b3o4aEFmUjRYRDdLaHNIUDFVb1RoQWJCRXVpTFExcmFi?=
 =?utf-8?B?Z01EdzRQQWxnUXcvMWNkTVU1elR0R3JoMjkxNnpBSWlBRm9yV2cva2ZtSzF3?=
 =?utf-8?B?N09KekJwcFZmVGZrcDRVaVRMa3hEVlNCT1lVY2lYeVZKL1BlYWs0QVpWVEtL?=
 =?utf-8?B?cHhHemgrYXc5L1h3Qk1ockIyTzZlYmtGU3hrVitHTGZaSGdOSWlIcVRFRFlW?=
 =?utf-8?B?bm1lMjB0VDdxS0FCWm9tNDlSWTg1L2NkQ0IxMXdHazJxT1JFMzVWTXY3aGJY?=
 =?utf-8?B?RVBiS2t3RzdOYk1IVTJWZXVFclU2anJOU1lxN2VtNGFnajI1SHZ0ZVRUTGRv?=
 =?utf-8?B?SjI0ZkZGcWQvbU5IaE83UFB6Znp1aDF2OWpOM1R4eG5waHNSOStJcCtvazhn?=
 =?utf-8?B?amw4VUhDNkNQdTVpWEgxeXI5MUs1OXJoYWVZSTl1ZVp6a2ZRZ0dTSFp0U3Ez?=
 =?utf-8?B?Mjc0WXNLUHhmbjUrTnJYTkxDclV5eHlya1VSVHFoYVFpWU0xeEYzaU1pUkFl?=
 =?utf-8?B?YkJjdUhOd1pRaVZSTzV6ZGNJekJXR2pVQjFQKzFUZW9VbCttM2VQcTZGbFFU?=
 =?utf-8?B?RFVkNSt0KzdKa294MVRyOHhvTTdZcmZDRjV0cGRJZFp5VUhRYU44UmdPR3hw?=
 =?utf-8?B?TG94Uy9YeThVWm1BWnN1cG5EZjF2K3A4dHVKSDdJNVNyVnVkbkFkREhxYmZ3?=
 =?utf-8?B?NGpvL0hPTnFvdXJaSEVGSHRwN1hnam1aVVZkbE12SjV4NGhFVHRIRW1yWDkr?=
 =?utf-8?B?V240cFlaNURSTWM4Y2pxc3NhVi9jdlI4TmdodUd2UWpQUmVpMUVYNDlxN0RK?=
 =?utf-8?B?QWxuanN5eE5CbmR1alpiMStGZEV3SWc2UFNXWjRyZjJwWCtFRkJHcUMrL1Zk?=
 =?utf-8?B?dXQxNC9xb2N5bWF3UGw4M1o5SWpBZlNQMkVla3FSZ2hBREJrbDVnS0d3eVA3?=
 =?utf-8?B?dWtFdXAvVzF6RWlDYzY2emg2NFpJSVRSSkUrVDdmditaUWtROFg3S0JpMHRX?=
 =?utf-8?B?bDZ0ejduc1JzWXJrWjJxTjJCV2NEeldCd0YvWWFDcHFBVFNuUGdBY0hzQWl5?=
 =?utf-8?B?MWhIbVBjOHRpVUlMUi8wYUtiRXlNeTNUV213NkVqVC9icHcveEN1b0ZRV3Ev?=
 =?utf-8?B?eVFTZzI4MGJ5VlRXdFVzcCszdE1zUjZXYk54ME9IN3VzTWkvNWZEWkl4WlBl?=
 =?utf-8?Q?zwDEfDiY?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4597.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2021 11:01:48.2419
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-Network-Message-Id: 339399e8-1295-4eef-62e9-08d8b0a021f1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ubPFVEdLUOZy51kh72bguWdR5REfewWFeTyJWYGye9sCBId9QtMr+qzhKnGtCoCcUFkIIa4fY36pAOOhfgfTkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3605
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Joerg / Will,

Happy New Year!! Just want to follow up on this series.

Thanks,
Suravee

On 12/15/20 2:36 PM, Suravee Suthikulpanit wrote:
> The framework allows callable implementation of IO page table.
> This allows AMD IOMMU driver to switch between different types
> of AMD IOMMU page tables (e.g. v1 vs. v2).
> 
> This series refactors the current implementation of AMD IOMMU v1 page table
> to adopt the framework. There should be no functional change.
> Subsequent series will introduce support for the AMD IOMMU v2 page table.
> 
> Thanks,
> Suravee
> 
> Change from V3 (https://lore.kernel.org/linux-iommu/20201004014549.16065-1-suravee.suthikulpanit@amd.com/)
>    - Rebase to v5.10
>    - Patch  2: Add struct iommu_flush_ops (previously in patch 13 of v3)
>    - Patch  7: Consolidate logic into v1_free_pgtable() instead of amd_iommu_free_pgtable()
>    - Patch 12: Check ops->[map|unmap] before calling.
>    - Patch 13: Setup page table when allocating domain (instead of when attaching device).
> 
> Change from V2 (https://lore.kernel.org/lkml/835c0d46-ed96-9fbe-856a-777dcffac967@amd.com/T/#t)
>    - Patch  2: Introduce helper function io_pgtable_cfg_to_data.
>    - Patch 13: Put back the struct iommu_flush_ops since patch v2 would run into
>      NULL pointer bug when calling free_io_pgtable_ops if not defined.
> 
> Change from V1 (https://lkml.org/lkml/2020/9/23/251)
>    - Do not specify struct io_pgtable_cfg.coherent_walk, since it is
>      not currently used. (per Robin)
>    - Remove unused struct iommu_flush_ops.  (patch 2/13)
>    - Move amd_iommu_setup_io_pgtable_ops to iommu.c instead of io_pgtable.c
>      patch 13/13)
> 
> Suravee Suthikulpanit (13):
>    iommu/amd: Re-define amd_iommu_domain_encode_pgtable as inline
>    iommu/amd: Prepare for generic IO page table framework
>    iommu/amd: Move pt_root to struct amd_io_pgtable
>    iommu/amd: Convert to using amd_io_pgtable
>    iommu/amd: Declare functions as extern
>    iommu/amd: Move IO page table related functions
>    iommu/amd: Restructure code for freeing page table
>    iommu/amd: Remove amd_iommu_domain_get_pgtable
>    iommu/amd: Rename variables to be consistent with struct
>      io_pgtable_ops
>    iommu/amd: Refactor fetch_pte to use struct amd_io_pgtable
>    iommu/amd: Introduce iommu_v1_iova_to_phys
>    iommu/amd: Introduce iommu_v1_map_page and iommu_v1_unmap_page
>    iommu/amd: Adopt IO page table framework for AMD IOMMU v1 page table
> 
>   drivers/iommu/amd/Kconfig           |   1 +
>   drivers/iommu/amd/Makefile          |   2 +-
>   drivers/iommu/amd/amd_iommu.h       |  22 +
>   drivers/iommu/amd/amd_iommu_types.h |  43 +-
>   drivers/iommu/amd/init.c            |   2 +
>   drivers/iommu/amd/io_pgtable.c      | 564 +++++++++++++++++++++++
>   drivers/iommu/amd/iommu.c           | 672 ++++------------------------
>   drivers/iommu/io-pgtable.c          |   3 +
>   include/linux/io-pgtable.h          |   2 +
>   9 files changed, 707 insertions(+), 604 deletions(-)
>   create mode 100644 drivers/iommu/amd/io_pgtable.c
>