Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp13766824pxu; Mon, 4 Jan 2021 04:02:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJz1V0uCYOTmR939oYA6Zn8dzq78fIsxnmfOnlg8qPRHzcp8Q3WYuPaJkt2jgdF7XArr4EJh X-Received: by 2002:a05:6402:128d:: with SMTP id w13mr17622471edv.56.1609761772964; Mon, 04 Jan 2021 04:02:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609761772; cv=none; d=google.com; s=arc-20160816; b=flU3TEzz1kYUHtQ2wfvIMKSlMqKvAu9nmup99K/HkY/hvZKGc9qVmdqQ9Kp+wfOdo4 9bep47ja438OIrH0kF1kMm8JKo9AQmc/wpYCDwyLLT4KLknigqQ2glB3H1MPu/RL+9qC Uzca6jnH5XEhleZ/jtRSgR2qfZ2xfI7bLlH2DAWykEjnYCR83mzclO7K8jXhjc1h3r5C N8FL64lfJuR1+BHQq/AM6sGRXmq4E89WmGiRaJuOfUOVQXJq+NQ3llQb6PNJWEDyhmNN mTqKDtCrpKEQUHWFKqh1nNeTrF/x1lej6IphAjb56jx2VfrK1NJ/o5jqZj5EvKftqxFb uWaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=2V5hcnRaeIXIpQcqixpTyxjyts/WiqpPABAhyq+UXtQ=; b=ghQkCQJhfkyJ/fnQL3ixQ5N5481lUC22pcYbV7QJZu+04ajiesQcn356VYpQd0Nxj3 yeQobSK5nf9XJUJrZZGY9KFPGBMiEmLxhdXvGESSVnxX9HAw0XfahN358fwEXqDkSmeS 4khEWoOK7a0T8rgbaUyXUa1Q/u0K9uGScufqhmDdgr6uaraiXAwcD04Nv43viWLJ2ZOG x5B4Q9X8CmAdNnA64fTttnVZur7EfYFFWwzhOMYylgPuZkJTv+Lxfo/dmiKOBlvYKMiR at7pdJQ2xWtjNzsNquL8eK+xivRz3woDVvKudHAOKAOOlvM1Nooblep4ubeovlEEA5nO 2p0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm6si29359727ejc.159.2021.01.04.04.02.29; Mon, 04 Jan 2021 04:02:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbhADMB6 (ORCPT + 99 others); Mon, 4 Jan 2021 07:01:58 -0500 Received: from correo.us.es ([193.147.175.20]:58796 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbhADMB5 (ORCPT ); Mon, 4 Jan 2021 07:01:57 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id BFE7A1C438D for ; Mon, 4 Jan 2021 13:00:39 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B2F00DA72F for ; Mon, 4 Jan 2021 13:00:39 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 9F485DA798; Mon, 4 Jan 2021 13:00:39 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 6155FDA789; Mon, 4 Jan 2021 13:00:37 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 04 Jan 2021 13:00:37 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 3DEAB426CC85; Mon, 4 Jan 2021 13:00:37 +0100 (CET) Date: Mon, 4 Jan 2021 13:01:13 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Yi Chen Cc: Shuah Khan , Florian Westphal , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Leo Subject: Re: [PATCH net] selftests: netfilter: Pass the family parameter to conntrack tool Message-ID: <20210104120113.GA20112@salvia> References: <20210104110723.43564-1-yiche@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210104110723.43564-1-yiche@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please, Cc netfilter-devel@vger.kernel.org, and a more few comments below. On Mon, Jan 04, 2021 at 07:07:23PM +0800, Yi Chen wrote: > From: yiche > > Fix nft_conntrack_helper.sh fake fail: > conntrack tool need "-f ipv6" parameter to show out ipv6 traffic items. > sleep 1 second after background nc send packet, to make sure check > result after this statement is executed. Missing Fixes: tag ? > Signed-off-by: yiche > --- > .../selftests/netfilter/nft_conntrack_helper.sh | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/netfilter/nft_conntrack_helper.sh b/tools/testing/selftests/netfilter/nft_conntrack_helper.sh > index edf0a48da6bf..ebdf2b23c8e3 100755 > --- a/tools/testing/selftests/netfilter/nft_conntrack_helper.sh > +++ b/tools/testing/selftests/netfilter/nft_conntrack_helper.sh > @@ -94,7 +94,13 @@ check_for_helper() > local message=$2 > local port=$3 > > - ip netns exec ${netns} conntrack -L -p tcp --dport $port 2> /dev/null |grep -q 'helper=ftp' > + if [[ "$2" =~ "ipv6" ]];then > + local family=ipv6 > + else > + local family=ipv4 This branch coding style diverges from the existing code. > + fi