Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: i6V5r2H9h4gkVbFlnAER8oRXNV9bi9wIa8upERa+cj0ltYQfPJ6SwllsBWLyyLrr1ClxBwavsI
 HsC/E6wy4UVTeidQzdEv7R4lInu35grPiygmM+Xo+NZUf3K5ezxEpH1g/X7WnEOxhavLfppOyT
 gEFlBnaJgblJRsFYaJX7FahWoHqEHLetjNFLcnvyXkQz617XyKurEPbKByHUFQtNbvrhF3ZNzT
 96+5iwN6BU/w2rrG27bVET73WsZhe6fmQe0NFTpjE2gOd1ACrGVOHYKUyPpJtjcwZrODIHOdFg
 LkM=
Message-ID: <5e5332e026af5d3716cf9bb0aa404783b53f9e02.camel@microchip.com>
Subject: Re: [PATCH v11 3/4] phy: Add Sparx5 ethernet serdes PHY driver
From:   Steen Hegelund <steen.hegelund@microchip.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Bjarni Jonasson <bjarni.jonasson@microchip.com>,
        Microchip UNG Driver List <UNGLinuxDriver@microchip.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>
Date:   Mon, 4 Jan 2021 14:16:38 +0100
In-Reply-To: <20210104121502.GK31158@unreal>
References: <20210104082218.1389450-1-steen.hegelund@microchip.com>
         <20210104082218.1389450-4-steen.hegelund@microchip.com>
         <20210104121502.GK31158@unreal>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Leon,


On Mon, 2021-01-04 at 14:15 +0200, Leon Romanovsky wrote:
> 
> <...>
> 
> > +struct sparx5_sd10g28_args {
> > +     bool                 skip_cmu_cfg; /* Enable/disable CMU cfg
> > */
> > +     bool                 no_pwrcycle;  /* Omit initial power-
> > cycle */
> > +     bool                 txinvert;     /* Enable inversion of
> > output data */
> > +     bool                 rxinvert;     /* Enable inversion of
> > input data */
> > +     bool                 txmargin;     /* Set output level to 
> > half/full */
> > +     u16                  txswing;      /* Set output level */
> > +     bool                 mute;         /* Mute Output Buffer */
> > +     bool                 is_6g;
> > +     bool                 reg_rst;
> > +};
> 
> All those bools in structs can be squeezed into one u8, just use
> bitfields, e.g. "u8 a:1;".

Got you.

> 
> Also I strongly advise do not do vertical alignment, it will cause to
> too many churn later when this code will be updated.

So just a single space between the type and the name and the comment is
preferable?

> 
> > +
> 
> <...>
> 
> > +static inline void __iomem *sdx5_addr(void __iomem *base[],
> > +                                   int id, int tinst, int tcnt,
> > +                                   int gbase, int ginst,
> > +                                   int gcnt, int gwidth,
> > +                                   int raddr, int rinst,
> > +                                   int rcnt, int rwidth)
> > +{
> > +#if defined(CONFIG_DEBUG_KERNEL)
> > +     WARN_ON((tinst) >= tcnt);
> > +     WARN_ON((ginst) >= gcnt);
> > +     WARN_ON((rinst) >= rcnt);
> > +#endif
> 
> Please don't put "#if defined(CONFIG_DEBUG_KERNEL)", print WARN_ON().

OK, I will drop the #if and keep the WARN_ON...

> 
> Thanks

Thank you for your comments.

BR
Steen