Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp13849635pxu; Mon, 4 Jan 2021 06:15:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhJzuYTZ2pfXx8yU2CHFN/y4Rmwp7+dPIX/J89bDebjUyZHyy8xLp9W1IB3a5TI5hJRQob X-Received: by 2002:a05:6402:c0b:: with SMTP id co11mr69622509edb.180.1609769719057; Mon, 04 Jan 2021 06:15:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609769719; cv=none; d=google.com; s=arc-20160816; b=teiZdmxhnm31JXfjHQr3UOvyRfYAvelL+nSi1ZJBFhgE8zwpWO2cknoW9srA2VRpDn g3GPP9fS5G/KwICsNnM1QvRgvOkWQTct38xcga8Ko+b3oHaAHrqSEG83KespF4vOEOob rRViX2xtzTa9tsXSAiuaP//VLxXEBUd3iDhzefwKrJ4IBAr7Y6bjKlY3hRMhokyA99Vl 0VKR7f6+QEIPcwCg6fkiVXFbQxgqUgSuArvnIPb2W8z9aeihYl6/l2ONW6d1lVAWGfCy kMxloNBUxudnZl26rcpCbK8DOKm+uUAfRXra7VjZA3x5aKDeQTTSLlZ2vkO+qYkCiOWa Se4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=fYsqDdXgtAOBsrqosEYjqZaNVEtNGIrvfx5evJ98jf8=; b=EPz/6Np+M6TKk9ibLxMGFIHDnGAR4U4tZMeCD//0gJy4qVGyC4/aDbpOKjMkP4RsKm 7q95dRwndPWQfInS3Uk0gG3OoXFZTJdU/CL+ETLEtY6a1YisyQE5ZewkgY9XIeTFaJde 60tHJ/mBpfnKenyhCyvWXAq/Ov9ekUz7p8rnqjUPa0vwsM5RZvCx0Bjj5sdBN4WsfvKI uF0y3TIflcW2yGvVl1/IghRqv3ny3VRdMoe2SVKa5IfDJ6oZAiZJ9N1zRKO3K7nqWudm i/ijSCSFZev4Q47/zX2dX3o63wiLVyXO3TecwByz6MiT7GQo6iKscMeUe9XKUKArNkIO xKbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="uKW/2yvA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nq4si30449015ejb.68.2021.01.04.06.14.55; Mon, 04 Jan 2021 06:15:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="uKW/2yvA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726434AbhADOOL (ORCPT + 99 others); Mon, 4 Jan 2021 09:14:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:43972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbhADOOL (ORCPT ); Mon, 4 Jan 2021 09:14:11 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 95FB52245C; Mon, 4 Jan 2021 14:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609769636; bh=oqztWhFAZMPdxzyKlwb//7PmFe7TTLE83m1Z9TPVaEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uKW/2yvAczC2Qcx4GHy0h6O1SUctibjcRTVbNo6njkQqeWBgZiGOx7D1o2b9E9Lrb 17Io8T0KmdQe7/tHWrbr5QrxAARe8pIrHV8krqfTUwos2pTTTlqbmtmLp5axckNM0C G+MQKWwNq8XSLH0qyBJfTZYKL9WmXr91ozuo53y41S/2XFnaNbWUYeo98gLMbN/Bqd aoSzUbYZRlUTl+XiWX9OwCqifIfzGjB2uZPTBXiJT5soWNqZblYqryLjwuosbIbUfD sIuCQaXVGEx0jA5vwVBA/zJJOpEUwZBAl1pWaV4JYX0unGSkUMIdKf2Myiwg2SfCor ZbUPKhIIDY6iw== Date: Mon, 4 Jan 2021 14:13:29 +0000 From: Mark Brown To: Takashi Iwai Cc: Arnd Bergmann , Liam Girdwood , Arnd Bergmann , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH] ALSA: hda: fix SND_INTEL_DSP_CONFIG dependency Message-ID: <20210104141329.GG5645@sirena.org.uk> References: <20210103135257.3611821-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4eRLI4hEmsdu6Npr" Content-Disposition: inline In-Reply-To: X-Cookie: Stupidity is its own reward. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4eRLI4hEmsdu6Npr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 04, 2021 at 03:09:24PM +0100, Takashi Iwai wrote: > IMO, the problem is rather the unconditional calls of > snd_intel_dsp_driver_probe() in snd-soc-sof-pci and snd-soc-sof-acpi > drivers. Those calls should be done only if Intel drivers are > involved. So, wrapping the call with ifdef > CONFIG_SND_SOC_SOF_INTEL_PCI or CONFIG_SND_SOC_SOF_INTEL_ACPI would > work better (although those are a bit uglier). Or stubbing them which might be neater. --4eRLI4hEmsdu6Npr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/zIogACgkQJNaLcl1U h9Cs2gf+L8LA4jGPihc58O3+2gVfjpoTLwqR18RhrGsAJrQAhVjPb6+muvVH4rVw aKm648duaehQ4484pZXS/LUtyEw70+N8RHhchEfyfHu47SVF1Avku3rjsqSIZQF0 qNe8HDF5kJ0npw2mazr/Iv+P1Uv7Yti9GVye63MmAaImJe5HPX9DmfQspj3zeIXu NMFycv6wLpMoo4L0P5qxFxCkVKVZXSjeJED7/uXQVrtpSJzcWhU+cUn7HI/J48gl Esu9cmu5UJLHzMbVpzhHxbH/L6GGljPGWxRfWoP9gP/GasEfv5q3gjBHeOLsPEgp YnyLj/Uegu5vdqyK+bVllUs1klgm3A== =HwUk -----END PGP SIGNATURE----- --4eRLI4hEmsdu6Npr--