Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp13891399pxu; Mon, 4 Jan 2021 07:16:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTxq6zyg0P0f2Qu666nUWvWlmVBniPHbp/tgRV1OrCzMRcs4yFZSjfDb9Djfa/70NZbgE4 X-Received: by 2002:a17:906:e84:: with SMTP id p4mr54485986ejf.141.1609773395699; Mon, 04 Jan 2021 07:16:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609773395; cv=none; d=google.com; s=arc-20160816; b=xp0YHST73sMWLto4ClHQ3aWHFNmhtAVxIvzRE+VIkA6Xvtd2UyjP3PBPEJRiPHcdoc yO3liq+ZoXyqm3esDdmFaXT1ksrm+M5plezTfsbKZnUkLfkUf1eP1zmyEQ45WmCaxJL/ U0DTTm/lmYVUi6O2eI+EBqyTksqw71668ZYt1pbT3BzK6R+06L+Ik2XjnSz7s8Rayze6 czE2C2WXUd50wbEB7AHxVCe1b7CuKw+pqZeqv+Yrv5hi/GdvHDdJdsQER6dZLEBmhWbW dywWSSUp7+NIytJRGsKu9T5FB2Ret458+85CGEsakmsB4U50gL0kZDjakC4Q44sijDgw L4ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=d9r9HcXPQUTgBxIPgTao+g1akviwyeyLwv/73SOuEYw=; b=mlH9+vtRTX2B3n3xD0qVRU1cali+7DiN4OakODwnwLNWbphZCjQkCQnzQ7CNZzLrWP KzJCwAeQA7OYdMQBiQj3jp++J2+Ba8QKS/n6mUAO9v5/qcB1A4T5t2y8YoiF4d9WIXE0 hWpkcqi/ithcVID5pAONQ2cGTOlHATOE6IDMSeo+hANX4XvxBphgnIXwO2orey0Ar22S hbhXSXbTmhiEYsNUx2zI/sOIOnjKVp8ULcxbvbhU7tqFzXBzJlY0WY1aqA7tinWk28iO kN9NsggWyks2aE5vZyMTTqXd/lgc26et7gaVJe4+f74h8cqHI1bqjxj+eOTT8JipjlMr pzWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TftuA15p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h22si27953772ejd.179.2021.01.04.07.16.12; Mon, 04 Jan 2021 07:16:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TftuA15p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727335AbhADPNf (ORCPT + 99 others); Mon, 4 Jan 2021 10:13:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:53598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbhADPNf (ORCPT ); Mon, 4 Jan 2021 10:13:35 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7C1A9207BC; Mon, 4 Jan 2021 15:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609773174; bh=y69n2uWL97se0ZNSzSAZ4xOBtGGeaTn9m/nFYsgbPuo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TftuA15pdcB5H/azkWExQ7NeYgK0W2S/8tFpROZlj/qRrlTw9RE1bGJLMQf/C0y3m 1ee5QGlvfntDnzI/z52yfJpvBufOVZS6TjZBljKNM+99hh5A7/rwHKYa8MPf7hBdsO /+Kg7itGq8zOS2R4f08AQpI2U2B3vcWllMduq+7ubh/7wiiAqeMt6sOqA0SwZCmNb1 a+KL86e1JMWgetrNJ9LeDCKbBx7VZINmFxFkWjxq3zKmxLkXVXZVUQ3qh1R01D9dN0 RauTPdm6/hwgmzm61/BVFdZOh5SPuSqXnVAJC4YBypS7FXYuDzV6kpogTX9ZJXj1f2 VIksVt2bs1wsg== Date: Mon, 4 Jan 2021 16:12:51 +0100 (CET) From: Jiri Kosina To: Zhang Lixu cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.pandruvada@linux.intel.com, benjamin.tissoires@redhat.com Subject: Re: [PATCH 0/2] hid: intel-ish-hid: ipc: enable OOB support for EHL In-Reply-To: <20201216063640.4086068-1-lixu.zhang@intel.com> Message-ID: References: <20201216063640.4086068-1-lixu.zhang@intel.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Dec 2020, Zhang Lixu wrote: > The EHL (Elkhart Lake) based platforms provide a OOB (Out of band) > service, which allows wakup device when the system is in S5 (Soft-Off > state). This OOB service can be enabled/disabled from BIOS settings. > > These two patches is to enable this feature for EHL platform. > > We have tested these patches on both ISH platforms and EHL platforms, > it works fine. > > Zhang Lixu (2): > hid: intel-ish-hid: ipc: finish power flow for EHL OOB > hid: intel-ish-hid: ipc: Address EHL Sx resume issues > > drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 + > drivers/hid/intel-ish-hid/ipc/ipc.c | 27 +++++++++++++ > drivers/hid/intel-ish-hid/ipc/pci-ish.c | 54 ++++++++++++++++++++++++- > 3 files changed, 81 insertions(+), 1 deletion(-) Srinivas, can I please get your Acked-by / Reviewed-by for this? Thanks, -- Jiri Kosina SUSE Labs