Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201114130921.651882-1-jiaxun.yang@flygoat.com>
 <20201114130921.651882-2-jiaxun.yang@flygoat.com> <CAMuHMdXo9o9af-YBt5g53QHRhuLxdSy_C9n4wdEEh7yzDidr-w@mail.gmail.com>
 <20210104144841.GC3313@piout.net> <CAMuHMdWGnBcYvXLnydSnkxcmG6GksZLfq1aWADuWg8ibZ3V8Lg@mail.gmail.com>
 <20210104154303.GD3313@piout.net>
In-Reply-To: <20210104154303.GD3313@piout.net>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 4 Jan 2021 16:51:40 +0100
Message-ID: <CAMuHMdW2nDwJGmOtoDgOEMgEDaD9nMMCv=Y4nZaDqCM1UNadvQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-rtc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Alexandre,

On Mon, Jan 4, 2021 at 4:43 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 04/01/2021 16:21:31+0100, Geert Uytterhoeven wrote:
> > On Mon, Jan 4, 2021 at 3:48 PM Alexandre Belloni
> > <alexandre.belloni@bootlin.com> wrote:
> > > On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote:
> > > > On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> > > > > Goldfish platform is covered with dust.
> > > > > However the goldfish-rtc had been used as virtualized RTC
> > > > > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
> > > > > we can drop other parts of goldfish but leave goldfish-rtc here.
> > > > >
> > > > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > > --- a/drivers/rtc/Kconfig
> > > > > +++ b/drivers/rtc/Kconfig
> > > > > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
> > > > >  config RTC_DRV_GOLDFISH
> > > > >         tristate "Goldfish Real Time Clock"
> > > > >         depends on OF && HAS_IOMEM
> > > > > -       depends on GOLDFISH || COMPILE_TEST
> > > > >         help
> > > > >           Say yes to enable RTC driver for the Goldfish based virtual platform.
> > > >
> > > > I was just looking to see if someone had already sent a patch to add
> > > > "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
> > > > noticed your patch had removed it...
> > > >
> > > > What about
> > > >
> > > >     depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST
> > > >
> > > > instead?
> > > >
> > >
> > > But this driver also works on ARM, is it really important to restrict to
> > > a few architectures ?
> >
> > Is it used on ARM platforms?
> > qemu:hw/riscv/Kconfig selects GOLDFISH_RTC, but that's it?
>
> My understanding is that this was used on the original ARM based goldfish
> android emulator but I don't think this was ever upstreamed.

Upstream indeed only has GOLDFISH support in arch/x86/Kconfig.
Still, that would be handled by the dependency on GOLDFISH.

Or do you mean upstream QEMU Goldfish support?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds