Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <dd3a0f2e8c9688f98b1c5a3c843db0570e4da139.camel@gmail.com>
Subject: Re: [PATCH v2 2/3] scsi: ufs: Add handling of the return value of
 pm_runtime_get_sync()
From:   Bean Huo <huobean@gmail.com>
To:     Can Guo <cang@codeaurora.org>
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com,
        asutoshd@codeaurora.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stanley.chu@mediatek.com,
        beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        rjw@rjwysocki.net
Date:   Mon, 04 Jan 2021 18:39:41 +0100
In-Reply-To: <88069c938a06b06f89cc4662cef3c1be@codeaurora.org>
References: <20201224172010.10701-1-huobean@gmail.com>
         <20201224172010.10701-3-huobean@gmail.com>
         <88069c938a06b06f89cc4662cef3c1be@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2020-12-28 at 09:50 +0800, Can Guo wrote:
> > The race issue may exist between UFS access in UFS sysfs context
> > and 
> > UFS
> > shutdown, thus will cause pm_runtime_get_sync() resume failure.
> 
> Are you trying to fix the race condition by adding these checks or
> just
> adding these checks in case pm_runtime_get_sync() fails?
> 
> Can Guo.

Can,
thanks for your review. Sorry, I didn't quite get your point.
This patch is just to add checkup in case pm_runtime_get_sync() failed.

what else should be added?

Bean