Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbWIGX6Q (ORCPT ); Thu, 7 Sep 2006 19:58:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751918AbWIGX6Q (ORCPT ); Thu, 7 Sep 2006 19:58:16 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:30358 "EHLO einhorn.in-berlin.de") by vger.kernel.org with ESMTP id S1751916AbWIGX6P (ORCPT ); Thu, 7 Sep 2006 19:58:15 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Fri, 8 Sep 2006 01:57:09 +0200 (CEST) From: Stefan Richter Subject: [PATCH 1/2] ieee1394: ohci1394: fix endianess bug in debug message To: linux1394-devel@lists.sourceforge.net cc: linux-kernel , Wolfgang Pfeiffer , Ben Collins , Andrew Morton In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 26 The transaction labels were misprinted int the debug printk "Packet received from node..." due two byte-swapping once too often. Affected were big endian machines, except UniNorth based ones. Signed-off-by: Stefan Richter --- Index: linux/drivers/ieee1394/ohci1394.c =================================================================== --- linux.orig/drivers/ieee1394/ohci1394.c 2006-09-06 23:50:53.000000000 +0200 +++ linux/drivers/ieee1394/ohci1394.c 2006-09-07 15:48:15.000000000 +0200 @@ -2743,7 +2743,7 @@ static void dma_rcv_tasklet (unsigned lo (cond_le32_to_cpu(d->spb[length/4-1], ohci->no_swap_incoming)>>16)&0x1f, (cond_le32_to_cpu(d->spb[length/4-1], ohci->no_swap_incoming)>>21)&0x3, tcode, length, d->ctx, - (cond_le32_to_cpu(d->spb[0], ohci->no_swap_incoming)>>10)&0x3f); + (d->spb[0]>>10)&0x3f); ack = (((cond_le32_to_cpu(d->spb[length/4-1], ohci->no_swap_incoming)>>16)&0x1f) == 0x11) ? 1 : 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/