Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp14016346pxu;
        Mon, 4 Jan 2021 10:32:29 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwGLC58XDT0ncedmM147QxlW73OZMCuBK0AQ3jZyKlqMbQDNk/Ey8QUo3CjZYIHxApqdQTG
X-Received: by 2002:a50:e848:: with SMTP id k8mr71857198edn.77.1609785149705;
        Mon, 04 Jan 2021 10:32:29 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1609785149; cv=none;
        d=google.com; s=arc-20160816;
        b=ejOGWAJtuXj+kei77pUA+kMd2rKTh0EjMCrSRu3huhY3yguIq+n/3ksffWaVUsS5JJ
         af5O0C+Maa0CjisN8il+HAGerVlR3ALqOPbdG8/8YireO6Jy8j95gKMUfgvnT+9vpE4N
         JSSyahMLZXQBdv84xE81oK2BbKLDbdmw9VCbCBAl9tyHUvVbFaH+zhBIV5GBT2rlByXc
         wsjp8EL31NEhgluaBTzFGYW6aGAMxxhi4/U1C/vIENH88LUASEn9tlxHFF/kbZv2vmB8
         CFuDY5Cn1Lh/VjcHLH5f6Z4hN8IbEtXpgpZvst6PcrQ6mIBxnfm6sfJVjdxyQmd0cAfm
         5lFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=7A8jLZ0lvhJljrb2gH9A5kAR2WAqiSXNUBkcA6H5oNw=;
        b=bfDVUfRqolLayQSA663jGUb5GZn+ZbYwc4k2DzkxEcWWbeew5Wo1V+ACFk0FQGB2qj
         ZyxoQYRjRF6RsUdpSYNTO45EfcVCTx+G4dKt4Gg+ZLxefp8hQbBKk7cD66DHCWtdYbPm
         ys2jzKLtl6ApYeimRFelu9de8ZVuD0T5uL6cxnB7oZHIQcC5xwlKWUUZRdTBmk1qY0+n
         bWmWZ9BLWEcLQbNus05yy5lWcNDghoMpy82XLT6pzKjqAYNLZZ3/KSZMgErr+a/OTHIc
         SlVcCSEdXSjdBXlY+VZw4gjQmTn2ubxsewfgDdPUQAERQNfYAyD58QSkDCB0GFYSAICO
         fUlg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dDqw+MPO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p14si28642791ejf.275.2021.01.04.10.32.06;
        Mon, 04 Jan 2021 10:32:29 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dDqw+MPO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727720AbhADSaK (ORCPT
        <rfc822;linuxmailingsubscription@gmail.com> + 99 others);
        Mon, 4 Jan 2021 13:30:10 -0500
Received: from mail.kernel.org ([198.145.29.99]:44688 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727646AbhADSaJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Jan 2021 13:30:09 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id CF0FB21D94;
        Mon,  4 Jan 2021 18:29:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1609784969;
        bh=M+ZYceuHxSxu607BknFIjQEagqcKWEToLDCHrHzKvQg=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=dDqw+MPOOOK4kb9xXl5/Xn3RUwybNH5M7WhqjcCsQ1FGiphvuRyidBBr+ex88uUpM
         Tcah4D6j9dgqu+JuBO17ErJkPm8+4iGANHBnb+YARD5m72kL5mALXvKLW+yf73Tlb7
         MPNrm8BV/cViqhGjQXjmtIIsdYqBHPrNvYs3mR5UDU+/PcgRkxy7CiCHdyVqsLZQpy
         B7wPtZshZdZCq8sXuDZ924b/FqFlspKmimgC2qn+TN/5eotkii2ndAc9UGlztkN+S0
         W4wA6dtmvMK/PcMKCU3zVLadZ4Plxrr+dCuyZeDCcSIAJAgLuDd/mCm8TE7ofUu71j
         /VhqPtVhIN74g==
Date:   Mon, 4 Jan 2021 10:29:27 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Gao Yan <gao.yanB@h3c.com>
Cc:     <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <paulus@samba.org>, <davem@davemloft.net>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v2]net:ppp: remove disc_data_lock in ppp line
 discipline
Message-ID: <20210104102927.2712cc10@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210101033718.45198-1-gao.yanB@h3c.com>
References: <20210101033718.45198-1-gao.yanB@h3c.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 1 Jan 2021 11:37:18 +0800 Gao Yan wrote:
> In tty layer, it provides tty->ldisc_sem to protect all tty_ldisc_ops
> including ppp_sync_ldisc. So I think tty->ldisc_sem can also
> protect tty->disc_data, and the disc_data_lock is not necessary.
> 
> Signed-off-by: Gao Yan <gao.yanB@h3c.com>

Please make sure to CC netdev.