Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp14062326pxu; Mon, 4 Jan 2021 11:50:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuEc1YNTbv9oF1jjOhmnQRdDsx2bNFpQTFHNZrt/D5ENDr+8XJqXiR7i/F5XFdfY0CIXP+ X-Received: by 2002:a17:906:cec7:: with SMTP id si7mr66560817ejb.123.1609789841707; Mon, 04 Jan 2021 11:50:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609789841; cv=none; d=google.com; s=arc-20160816; b=u0w1xocFVEW+z24mb9i7qIOBjIxs3Q4tBbCjFLONlCzjxcN0PvQpzYYq3WcE7USeVI 602b7y2gnzBVqzWXyFSDzx4bRG2ZisvMYt6dJLmACn6a5+N65Qv8HIy0l021JZh+ZNgO 0kZh6pY41PQKLlpphpKH2vyCm+NQJUm7mjhoXyLp/YKW0fTZ46F+VNit5wLwO1zziHdY X9vdHJ+eeIomdxScmk9Y/tDumdp9ORfTfOzck827W+JNQJxC1czfdSVMitnb4HN6Ik1B RZzactmkUZBVvpgXwRtTcyEySwQkUvz9Qs6XELPrfRpoT2z2hL/SPTDOGNRUXpY0it3G RZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=o20NGXDu8Wr4CtOlAkxS2p16Gjno1X/I0gPFUqhpoNs=; b=0mIXWg/ctwoHxCGqMegQpxSSyvKtu7bqWy9zBXmNoavqxEwACHN/poCOxXfdwHpqlm bSniyq8nULgvIxS0BYGpgo/qehQQhOQstQAw/7WPHGvSeBU5b5Jpo/61B6yCUP7gbjh6 L+vLuHVN6N5PzwD/wGQ8bnuCrzU5SViebK0sza2w3D97RVOkVcjhVzutQYqWlOpkfRmK N4QKFgELKJkSmTMJpRCbMT58jErKKgiH88ItwadswOlHJHCo/FiTqOrNuTovJmpUoKjy EG7X6akeaNwWa4F1HX0CY7csGWNsDElM4ytFGdOcoYHIlWfW1MlNNKbREsx/9A40/RXM 9a/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tu3FOadw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k4si32370094eds.355.2021.01.04.11.50.17; Mon, 04 Jan 2021 11:50:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tu3FOadw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726497AbhADTtY (ORCPT + 99 others); Mon, 4 Jan 2021 14:49:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:58566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbhADTtY (ORCPT ); Mon, 4 Jan 2021 14:49:24 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 83E2820780; Mon, 4 Jan 2021 19:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609789723; bh=CltlxWNEK/C+c6lCweLqAl+rBPr8Ap+pY2+oZ3aum7I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tu3FOadwcmvfUJKILnnxHOhuh34tzF/6hK4lA9c90JLYLOSaQym6ICCD9o/0UKB75 7HVqJmPoI2uWcv+dZeYkPaTft1W+V8/1yeZEDfS7uX7+NDsAsjPGb3oyUidj1kFqpK yL305eGwbvo0c3s/+VEf+fsQ+wOiNsAmLVxmBFzTrkojmhBDvjdwztE71oJ7T3tSVf StFb7jztUEW+t+AESmNAmQXWN3EI9MLS+rm6zdn9KOsTiOGXRuMBSajdgL+ywn6HrQ YTiffniLDHF1kcmNoXCrfGWYZ4ks1VyyMvMfVCmizNUZoFP9YLsSXNpo/ebysY41Dx 9oIxobsCcU+AA== Date: Mon, 4 Jan 2021 11:48:42 -0800 From: Jakub Kicinski To: Bongsu Jeon Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfc@lists.01.org, Bongsu Jeon Subject: Re: [PATCH net-next] nfc: Add a virtual nci device driver Message-ID: <20210104114842.2eccef83@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20201228094507.32141-1-bongsu.jeon@samsung.com> <20201228131657.562606a0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 Dec 2020 14:22:45 +0900 Bongsu Jeon wrote: > On Tue, Dec 29, 2020 at 6:16 AM Jakub Kicinski wrote: > > > > On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote: > > > From: Bongsu Jeon > > > > > > A NCI virtual device can be made to simulate a NCI device in user space. > > > Using the virtual NCI device, The NCI module and application can be > > > validated. This driver supports to communicate between the virtual NCI > > > device and NCI module. > > > > > > Signed-off-by: Bongsu Jeon > > > > net-next is still closed: > > > > http://vger.kernel.org/~davem/net-next.html > > > > Please repost in a few days. > > > > As far as the patch goes - please include some tests for the NCI/NFC > > subsystem based on this virtual device, best if they live in tree under > > tools/testing/selftest. > > thank you for your answer. > I think that neard(NFC deamon) is necessary to test the NCI subsystem > meaningfully. > The NCI virtual device in user space can communicate with neard > through this driver. > Is it enough to make NCI virtual device at tools/nfc for some test? I'm not sure if I understand. Are you asking if it's okay for the test or have a dependency on neard?