Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp14064612pxu; Mon, 4 Jan 2021 11:55:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJz0IEnQbiep6zOfW1A2p0yvpQzdmm3W9lUS3KV5Z1HR+IjNNZsGqFLYzSf5N+X5/v+8CH55 X-Received: by 2002:a17:906:edc8:: with SMTP id sb8mr68267763ejb.247.1609790132259; Mon, 04 Jan 2021 11:55:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609790132; cv=none; d=google.com; s=arc-20160816; b=BwogHYxWaMEqhC3upH+cbGWdjF+WVswHgZVrIMVzkMrgOTXwy87bicgvqO94gaE0xi 4UHSIOpuH5ACqhzDUjx+Uv+cEklQvD14YLrWrMUbPjuPbwJJcrmvIuQousRGzEbccNPk yDTGvJZ3m5GXCxsr+V2HjtoUoXoEHJfKIBEHJJ6A0OUJ5RJAS7QU8vVx9zkS6gCWOKEY HwlE+yiefYTkcE4kAG8ZCsFk9LdfLpZ0X2LygvTUbauiBDHCdnpA3NS8tV4n2Jx1fGeu bKjIV/cx6Apm1YfQeiWfrOM5svlTCxo/BX8+CsnscEY6+tUUj3fWERSRUBADdLnO8wBD Enug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=ZfvyNh8+Kf6oMqPeSe5DAfmIQKmpqVWS+D3w2XXZlJU=; b=DIgmzvW6XIulHZxgYe7IdmGjs7IcW3P2k80fuOXuj+tiq98Vqq4l/O/MaBMijpLF4Z Ag8WxueCzSstY2bZr8WIp6Ptq0dQvl3q2vUH6aG+FkA5CleW27n0+KPZCrj35NDTp7I3 BYb/UX//tv5rz+TsZaAYx7Za3P7WMNJiJCsx9Azo9+XdfLhiaS329MjqmVHYcz7q7qUt dDICnmkaSBmA1szfJEW0+tJHNrNq2Yiuy0LnFgxlB67q5TT4WMrmMf8XJ2J5/FhS04vO usHLEGuRlGYvlqkiUNZsi1NDX1vODbeQ9JhxVw5qzGTCRKDdqypGS/mXVOhCt2VJ35IP zJAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo25si29987078ejb.575.2021.01.04.11.55.08; Mon, 04 Jan 2021 11:55:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbhADTwU (ORCPT + 99 others); Mon, 4 Jan 2021 14:52:20 -0500 Received: from mga02.intel.com ([134.134.136.20]:62805 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbhADTwU (ORCPT ); Mon, 4 Jan 2021 14:52:20 -0500 IronPort-SDR: 34Fr6Y/hsOFPfoYh5T36kXDCebKrC4JeO1nV7m0Odqa3h0hblpElYDgWmRqllvP3xHO+pQJjMJ b9cQISZEAd4A== X-IronPort-AV: E=McAfee;i="6000,8403,9854"; a="164072528" X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="164072528" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 11:51:39 -0800 IronPort-SDR: v0UwUp+5vwbFq4JyY1Er7FVrevQOvPRRh5e7PmUy2+g5f3VxvDpJdjQp2bFpkIO9X++aE09byf UI+n66WkS0Mw== X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="360888996" Received: from trhudson-mobl.amr.corp.intel.com (HELO [10.213.162.49]) ([10.213.162.49]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 11:51:39 -0800 Subject: Re: [RFC v2 PATCH 4/4] mm: pre zero out free pages to speed up page allocation for __GFP_ZERO To: Matthew Wilcox Cc: Alexander Duyck , Mel Gorman , Andrew Morton , Andrea Arcangeli , Dan Williams , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang , Michal Hocko , Liang Li , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org References: <20201221163024.GA22532@open-light-1.localdomain> <0e8b6a2f-527d-7c77-efcf-04f21ef2a77c@intel.com> <20210104192753.GD22407@casper.infradead.org> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Mon, 4 Jan 2021 11:51:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210104192753.GD22407@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/4/21 11:27 AM, Matthew Wilcox wrote: > On Mon, Jan 04, 2021 at 11:19:13AM -0800, Dave Hansen wrote: >> On 12/21/20 8:30 AM, Liang Li wrote: >>> --- a/include/linux/page-flags.h >>> +++ b/include/linux/page-flags.h >>> @@ -137,6 +137,9 @@ enum pageflags { >>> #endif >>> #ifdef CONFIG_64BIT >>> PG_arch_2, >>> +#endif >>> +#ifdef CONFIG_PREZERO_PAGE >>> + PG_zero, >>> #endif >>> __NR_PAGEFLAGS, >> >> I don't think this is worth a generic page->flags bit. >> >> There's a ton of space in 'struct page' for pages that are in the >> allocator. Can't we use some of that space? > > I was going to object to that too, but I think the entire approach is > flawed and needs to be thrown out. It just nukes the caches in extremely > subtle and hard to measure ways, lowering overall system performance. Yeah, it certainly can't be the default, but it *is* useful for thing where we know that there are no cache benefits to zeroing close to where the memory is allocated. The trick is opting into it somehow, either in a process or a VMA.