Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp14067500pxu; Mon, 4 Jan 2021 12:00:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKa2Jr5iJjugoAip86Mo8/JSoL8q6LQAfyHJK0mZBfQlFvaLXVwTKhSehqQSC3OAIBhBBi X-Received: by 2002:a17:907:414c:: with SMTP id od20mr67403090ejb.75.1609790449899; Mon, 04 Jan 2021 12:00:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609790449; cv=none; d=google.com; s=arc-20160816; b=pUM1+J/eXUwqFMR7jRN0QVqz2B+cWv480Ne6DrckCCdP+LBxzMvITPF9it5wlvkWYP r1zUMjifPeZdYIa2mPU7ZoZBTD+iCbCcUONNOkUNIwbxb55ZSY+qxmptwTXDYnPwfpqM vT0ll2qktajc2zL+7Xsj9qJOVYGGcahUvWK+l9zFpAAhaHjcRXOLn6w8U1P2JtOAbJwn 0IHy/6nK5OnZgZjfUOo4ql6vvyfKumpfuOadwqhDGHeRUv1fose5A4t559/kbvBNuc6h LMr/1IHGvwb/GHBoGmxVmAPmPyHclEtNhbzVysorItfdlhWT/JmgxatqQwbmWFlsdKjD n51A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=0/gU3Gays2AOZSg4NOGtjLAjgq1YQdDpSGfnHt26+wA=; b=OR0GPozbpm12q2KC2nj2L2QoE3PkqB6j4KwKQ2uBWo0xRdP3ibRdkB115oytgMr6Mq IXFd5l4pjREzVgsrjtknPUNKE1OpeWB4CrpW1shSnUdD6PnwmRQ7Ol483i4lV6hOuV8Y 7lj8Evdl5hK1WTALxbeze5lNLpEKS4H5jdvkx9QhivbbLa+9neSccqIsuqLU9cSaiqUx eoe/iirFBvVUz6GOBwftHqwdxLSqmKMsM0A/JlZG9ZbiREpSM+Cy+AEtQMMJqh95kVpN WhZXdxc4Djx2uwn2GrdtyFSseuaC8w9ApLomcXKRHmRnyoDNg5IjC113bcICRXKrkJi+ 1loQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HQmM+7iD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e24si28788076edc.290.2021.01.04.12.00.25; Mon, 04 Jan 2021 12:00:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HQmM+7iD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727646AbhADT6z (ORCPT + 99 others); Mon, 4 Jan 2021 14:58:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbhADT6z (ORCPT ); Mon, 4 Jan 2021 14:58:55 -0500 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 045BBC061796; Mon, 4 Jan 2021 11:58:15 -0800 (PST) Received: by mail-pg1-x534.google.com with SMTP id e2so19762450pgi.5; Mon, 04 Jan 2021 11:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0/gU3Gays2AOZSg4NOGtjLAjgq1YQdDpSGfnHt26+wA=; b=HQmM+7iDZ6EeD3CAr+MWD/le9Y3qOcO1a4/P/q8TDXY63PCOKQZ2sqSAgnLCZevaVe 7T1bjopmfq6rkAIM8QKp5xdzUK5D11EPKZUTa69a0x4XRjsFnZOqlf54v1LDVIUqTGiE dhx0Enmwo/cUwSXAwXGPpvSqpXV+qvpLs6bZrf1QVxzuHX1wW7ldUPagaKHdPuwD3FLT Z7l9Il1pSZzpARrIxZk/1x1y74kVpM+ApWaqatTmoDnmFLTvUAzkizxG6yuSj3AVBbjL nWEck2GToRweuDQJ6ICYg8gHIdP65+iLrPSNOr+LyliJGtTzYhdnQmAvpdVu+8qAcuXl neQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0/gU3Gays2AOZSg4NOGtjLAjgq1YQdDpSGfnHt26+wA=; b=Q55Luxbq+kfsh0PEsmhqWqhIyhX2XWDKbRCnXYHrQXhDoOxqpZLqr8Qokk9xdhHEdL WmXguXNYIZQLHDHk94NZhlhChVOhHn5jojUYLWk1SbxlzH1Ud51zuWvdSdifE5AfGOsT deFlttiIHbz5IDXc0q6UYbOpiGxNHRFveorQftlWQGB+XbW/4YYsUbdZOJRn8/Dwn60h 6f2sb2HPlSBmp6LsaRIoh2x+zB+XIDMHh3GugWEkC+NyDTklR61benpRQ/uQsHVmTiMC 6qnCoXOPuo9FQWwdWnCTpotML18JIQpWhFON/OULd8ZFHpkjl79hJTQjuTQSq8VCk1+/ NUEQ== X-Gm-Message-State: AOAM533m/tl5TzHAoXueGA8O8O9CssGQySR6bqcSeiv0IAiEfY9QDovC ZU/fxT5nrCsqthq+IRKP5XLCyiD9x1E= X-Received: by 2002:a63:8c15:: with SMTP id m21mr58285016pgd.396.1609790292977; Mon, 04 Jan 2021 11:58:12 -0800 (PST) Received: from [10.67.48.230] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id d133sm52033844pfd.6.2021.01.04.11.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jan 2021 11:58:12 -0800 (PST) Subject: Re: [PATCH 2/2] net: dsa: lantiq_gswip: Fix GSWIP_MII_CFG(p) register access To: Martin Blumenstingl , hauke@hauke-m.de, netdev@vger.kernel.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20210103012544.3259029-1-martin.blumenstingl@googlemail.com> <20210103012544.3259029-3-martin.blumenstingl@googlemail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Mon, 4 Jan 2021 11:58:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210103012544.3259029-3-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/2/21 5:25 PM, Martin Blumenstingl wrote: > There is one GSWIP_MII_CFG register for each switch-port except the CPU > port. The register offset for the first port is 0x0, 0x02 for the > second, 0x04 for the third and so on. > > Update the driver to not only restrict the GSWIP_MII_CFG registers to > ports 0, 1 and 5. Handle ports 0..5 instead but skip the CPU port. This > means we are not overwriting the configuration for the third port (port > two since we start counting from zero) with the settings for the sixth > port (with number five) anymore. > > The GSWIP_MII_PCDU(p) registers are not updated because there's really > only three (one for each of the following ports: 0, 1, 5). > > Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Cc: stable@vger.kernel.org > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli -- Florian