Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbWIHBBE (ORCPT ); Thu, 7 Sep 2006 21:01:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751999AbWIHBBD (ORCPT ); Thu, 7 Sep 2006 21:01:03 -0400 Received: from mga02.intel.com ([134.134.136.20]:55375 "EHLO mga02.intel.com") by vger.kernel.org with ESMTP id S1751997AbWIHBBA (ORCPT ); Thu, 7 Sep 2006 21:01:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: i="4.08,227,1154934000"; d="scan'208"; a="122965041:sNHT51033346" Subject: Re: one more ACPI Error (utglobal-0125): Unknown exception code:0xFFFFFFEA [Re: 2.6.18-rc4-mm3] From: Shaohua Li To: Bjorn Helgaas Cc: kmannth@us.ibm.com, "Moore, Robert" , Len Brown , Mattia Dongili , Andrew Morton , lkml , linux acpi , KAMEZAWA Hiroyuki In-Reply-To: <200609070925.50145.bjorn.helgaas@hp.com> References: <1157573069.5713.24.camel@keithlap> <1157594624.2782.45.camel@sli10-desk.sh.intel.com> <200609070925.50145.bjorn.helgaas@hp.com> Content-Type: text/plain Date: Fri, 08 Sep 2006 08:57:08 +0800 Message-Id: <1157677028.2782.64.camel@sli10-desk.sh.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 (2.2.2-5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2525 Lines: 63 On Thu, 2006-09-07 at 09:25 -0600, Bjorn Helgaas wrote: > On Wednesday 06 September 2006 20:03, Shaohua Li wrote: > > On Thu, 2006-09-07 at 04:04 +0800, keith mannthey wrote: > > > On Wed, 2006-09-06 at 11:59 -0700, Moore, Robert wrote: > > > > From one of the ACPI guys: > > > > > > > > > Get hid > > > > > Look for driver > > > > > If you find a match, load it > > > > > If no match, get CID > > > > > Look for driver > > > > > If you find a match, load it > > > > > If you did not find an hid or cid match, punt > > > > > > I think this is what my patch is doing. > > > > > > when looking for a driver: (acpi_bus_find_driver) > > > I check against the HID > > > return if found > > > Then I check against the CID > > > return if found > > > else > > > punt > > > > > > Any objections to pushing this into -mm and dropping the motherboard > > > change? > > > I'd prefer not take this way. The ACPI driver model is already mess > > enough, let's don't make it worse. We are converting the ACPI driver > > model to Linux driver model, this will make the attempt difficult. > > I see that driver_bind() and driver_probe_device() don't mesh well > with the idea that multiple drivers might be able to claim a device, > because there doesn't seem to be a way to prioritize one driver > over another. Is that the problem you're referring to? Yes. > If we decide that "try HID first, then try CID" is the right thing, > I think we should figure out how to make that work. Maybe that > means extending the driver model somehow. Don't think it's easy, especially no other bus needs it I guess. > > We can let the motherboard driver not bind to your device (say we didn't > > register the motherboard driver, but just reserve the resource of the > > deivce). Is it ok to you? (I remember Bjorn said he wants to reserve the > > mem region of the device too). > > My point was that ACPI tells us what resources the device uses, > and we should reserve all of them so we accurately model the system. > > Reserving resources without registering the driver sounds like a hack > to work around broken behavior elsewhere, so I don't think it's a > good idea. Do we really need the memory hotplug device returns pnp0c01/pnp0c02? What's the purpose? Thanks, Shaohua - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/