Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp14170323pxu; Mon, 4 Jan 2021 15:03:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhhV0kTzXbAaquxfnIU5WR0W0RUrLOhJFda1urJzxVzoYKo2cXVy7wEcdpUpFnUIunJl57 X-Received: by 2002:a17:906:85cf:: with SMTP id i15mr71585475ejy.373.1609801392347; Mon, 04 Jan 2021 15:03:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609801392; cv=none; d=google.com; s=arc-20160816; b=NPY/yGFXV0XUZwKa3alWHcPxMyTyvNsQXwyWrO91YAFBN8Bzm75/1C6eYHlAH0hzG+ uXfo7siAwbFngIg936pNIUORwAVDZ05zCgiLZQk5FX/zspwhGVuQ7/oDBIPRdKqX8uJX rKV8SQiLXYaAI91M+nspP7J12/o2yBSbkTn87cvd+zidT/5FChKUQO+DTt7hTsY7mnxi veCtdr4eWLYk//eHvkjOhly2/YHTz93do533s5z2z4v/lqXW7d/LrL3HzC56TgKZkpeI Nwd0iGz4Xxnt1WuYae5FfenUvIkzMBlVJrJHS1iixDsK3v/lhzUyrObDEeG9Cr6gAbyC OyWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=mp2FFV2rc7QCdc34Tig7XyU/hnQUaRhR6eX1Mobu0KU=; b=iKhcRqTgPRqhZ/ltjhw2eIvQ3ezRiwpxHnUepVdBrFfm4iKbxvp/F2Kma/O6Wea5ps O4V3H5YU67S4ReYJd5T4OTFH064K+NHFiEd48NkNo8bgKr0zfZgYnvlM8sbdpWsJIhyf zjged9W4/VFpIKT7C7BCcGC2LRgCxzFgrT+kD8zHiyvvdTjv3aVbj7ZsMKU9/zVaDKiG 95JdM5T4tDdIbT4eDm49e2K5V35DU/YhGA2dhwR8fpGMUC7VCkdMlZl1O6WxxrEp7h3H K5vGI0VpzJMrxoW8RacIT/C4hOdrEIalFerdVUyiJN+VXOZ0rnw9cIKio6B2bilPo7H4 8GCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si31545432edv.606.2021.01.04.15.02.49; Mon, 04 Jan 2021 15:03:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbhADXBR (ORCPT + 99 others); Mon, 4 Jan 2021 18:01:17 -0500 Received: from mga05.intel.com ([192.55.52.43]:8938 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbhADXBR (ORCPT ); Mon, 4 Jan 2021 18:01:17 -0500 IronPort-SDR: PDnr+WH4/78RAgv54kk4zUT6O9wFOMWZZe5OStncKdaRbXXbr0ScOKxF3cKpFvrjY0hd8jVLB2 6MY6xRcePRcw== X-IronPort-AV: E=McAfee;i="6000,8403,9854"; a="261784382" X-IronPort-AV: E=Sophos;i="5.78,475,1599548400"; d="scan'208";a="261784382" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 15:00:32 -0800 IronPort-SDR: JTaMZyP7Q0sshosrow166L8VPmv8ZKWyp8gfmqrng2XLqpCfzo0trq7fUfGEIEhuJWMH6ZxjiG 1P8FsDgu0FnA== X-IronPort-AV: E=Sophos;i="5.78,475,1599548400"; d="scan'208";a="360940055" Received: from trhudson-mobl.amr.corp.intel.com (HELO [10.213.162.49]) ([10.213.162.49]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 15:00:31 -0800 Subject: Re: [RFC v2 PATCH 4/4] mm: pre zero out free pages to speed up page allocation for __GFP_ZERO To: David Hildenbrand Cc: Matthew Wilcox , Alexander Duyck , Mel Gorman , Andrew Morton , Andrea Arcangeli , Dan Williams , "Michael S. Tsirkin" , Jason Wang , Michal Hocko , Liang Li , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org References: <43576DAD-8A3B-4691-8808-90C5FDCF03B7@redhat.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <6bfcc500-7c11-f66a-26ea-e8b8bcc79e28@intel.com> Date: Mon, 4 Jan 2021 15:00:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <43576DAD-8A3B-4691-8808-90C5FDCF03B7@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/4/21 12:11 PM, David Hildenbrand wrote: >> Yeah, it certainly can't be the default, but it *is* useful for >> thing where we know that there are no cache benefits to zeroing >> close to where the memory is allocated. >> >> The trick is opting into it somehow, either in a process or a VMA. >> > The patch set is mostly trying to optimize starting a new process. So > process/vma doesn‘t really work. Let's say you have a system-wide tunable that says: pre-zero pages and keep 10GB of them around. Then, you opt-in a process to being allowed to dip into that pool with a process-wide flag or an madvise() call. You could even have the flag be inherited across execve() if you wanted to have helper apps be able to set the policy and access the pool like how numactl works. Dan makes a very good point about using filesystems for this, though. It wouldn't be rocket science to set up a special tmpfs mount just for VM memory and pre-zero it from userspace. For qemu, you'd need to teach the management layer to hand out zeroed files via mem-path=. Heck, if you taught MADV_FREE how to handle tmpfs, you could even pre-zero *and* get the memory back quickly if those files ended up over-sized somehow.