Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp14177269pxu; Mon, 4 Jan 2021 15:15:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJx75KKhvY3uhZlAXhaCbpgo4jF4Dbxi6elmmFvUqhu+1mlL4Z1m0bANHRvJueGiRCL0W1EZ X-Received: by 2002:a17:906:1288:: with SMTP id k8mr42844682ejb.206.1609802153877; Mon, 04 Jan 2021 15:15:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609802153; cv=none; d=google.com; s=arc-20160816; b=c/DFoVNngU9MvWfHBv8P1jIzGQ4GxCN3aWv1T9mDcqwMbggY9Ns+0rdUCMSbUo/Si3 Ft/aXKZEA+tKTiIASVsNCQmSyPOPlMwJ5XpzhBy7zM2U9vtowocx0/iNrl242EEeUtHO Y1PHLJUI0z1WZWFsAGgSkRauzb3qcESG3Qb02Yww4kKhGwYEP8fQ+CyOKgEB1BBCvy2a gCcD2o3npUUWpX/IxBeiiop/tbUKShMctUWNb8+J2le2YT6HZgthtx4JNH0B+52f8YB5 7OUhDJWk2bDT1CqzE1fyERFZHihn/fTjwPI0KODI3JYM2fuJgm8WCRmsYk/TS+T8l/YJ azjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nZJG52DxHM8NxYEaACeWBEq/7egLrC9ZK8TAPAUC9Tw=; b=MO63xFJf4HjLdVFMBSw6rRQRtWyNT/0WisqnTRirgE6Rcyv4vdBzIBdY2FQLDtOU6Z MqIg1mLPFke/dyISxbuAXmZEvHOWwFELRgWKeP3DTH98W31+3V0bhsb3CymNQkdkL1qo S4B6Xij2sIy2szkRA3HSAB8Pwl65VOAnpLpH4qWhhi4ubmEXeiCzeWAeKhWU5bGz8PIi UcLKcK3aySWOhNGE62Y3z6l7z+t6sjy5wdCZYIKypY4q7A1KxvR6qwd6cO+mmPFTfzcT x0Y8oDMKD9jljQk3A9DXiFb5vTTSzqP3tWTR9ukZDpnzJqwRgql1q63uL66bSCKVOpsZ u26w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bsAS2U5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c12si31590127eja.450.2021.01.04.15.15.30; Mon, 04 Jan 2021 15:15:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bsAS2U5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbhADXLz (ORCPT + 99 others); Mon, 4 Jan 2021 18:11:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbhADXLz (ORCPT ); Mon, 4 Jan 2021 18:11:55 -0500 Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACB90C061793; Mon, 4 Jan 2021 15:11:14 -0800 (PST) Received: by mail-vs1-xe36.google.com with SMTP id h6so15420470vsr.6; Mon, 04 Jan 2021 15:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nZJG52DxHM8NxYEaACeWBEq/7egLrC9ZK8TAPAUC9Tw=; b=bsAS2U5frW0z20sukfGBmeBZd50Frv6sTH0dmHyLmWie751Euilrw1VEXr+I4buBsY CFmFofP7b47XSYyOCFHJvYbNcqUTVIbLHsYlxSaP6QGGipxwfMm9RZJ1Ns0X5Pf3oTol JkuqIEf1PSfCUf00PRmuU60qMh1cDaP8jL/Z6B84dBXckskWxrHeFkRp7sTDsF3uRab3 i3Y7wGZG3YktDKV6qkIyoty6V7duCEKW7sWqriyl6JeFkw6HXBVrAuOj1svnOSOwjx8M P/LvDVjbvYhm/77s8YLyDADC9G5l8Qm3DiIlVqBomOepwqDtiRQUv6zl/OrPV8y4kq5A ckcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nZJG52DxHM8NxYEaACeWBEq/7egLrC9ZK8TAPAUC9Tw=; b=fXcWsPH4BMku64PKe1FyMbPJHMBYen66KU3WfSnJEJZYexQQs7I3iXH7Y1XGEM35Mt QGEdC+PDZcsKper7vjRWPA+BaN+EaIb4QIe++m+QXs5+sPMMxV7/0wXEWI/Pm1hd3ABa 9l0NPThVrnvnaTkYMy+VVhj0AQYUDvsG3bNvJHCbTfIkEhOkao6dpBCKRTOuoh/fVo/v bnNd7lPoM8OTPd2DQq2BadC4e7voEZ5XxS1XAy4ghBI6t8rmhdNVeCcn7NOUQyEsYELg PMPXFjiDg8NGscyDnsQSCEp3pmkkYMpExo/1sAvATSFTPFK3tKVUGvMaWc1mPbuwq2mj jLSg== X-Gm-Message-State: AOAM530VLrsBKcoW67t0jXjquff8im7mf3mGqC+QC0x9ixPJ+0vOf/d7 t/3PFnEJh1iaxgd2yyBZ4/RpcL/JnthrQg== X-Received: by 2002:a05:6214:20a7:: with SMTP id 7mr78391783qvd.59.1609798351740; Mon, 04 Jan 2021 14:12:31 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id k19sm37992586qkh.6.2021.01.04.14.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 14:12:30 -0800 (PST) Date: Mon, 4 Jan 2021 15:12:29 -0700 From: Nathan Chancellor To: Nick Desaulniers Cc: Masahiro Yamada , Arvind Sankar , Jakub Jelinek , Fangrui Song , Caroline Tice , clang-built-linux@googlegroups.com, Nick Clifton , Michal Marek , Arnd Bergmann , Andrew Morton , Randy Dunlap , Changbin Du , "peterz@infradead.org" , Thomas Gleixner , Krzysztof Kozlowski , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v3 2/2] Kbuild: implement support for DWARF v5 Message-ID: <20210104221229.GB1405526@ubuntu-m3-large-x86> References: <20201204011129.2493105-1-ndesaulniers@google.com> <20201204011129.2493105-2-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201204011129.2493105-2-ndesaulniers@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2020 at 05:11:27PM -0800, Nick Desaulniers wrote: > DWARF v5 is the latest standard of the DWARF debug info format. > > Feature detection of DWARF5 is onerous, especially given that we've > removed $(AS), so we must query $(CC) for DWARF5 assembler directive > support. GNU `as` only recently gained support for specifying > -gdwarf-5. > > The DWARF version of a binary can be validated with: > $ llvm-dwarfdump vmlinux | head -n 4 | grep version > or > $ readelf --debug-dump=info vmlinux 2>/dev/null | grep Version > > DWARF5 wins significantly in terms of size when mixed with compression > (CONFIG_DEBUG_INFO_COMPRESSED). > > 363M vmlinux.clang12.dwarf5.compressed > 434M vmlinux.clang12.dwarf4.compressed > 439M vmlinux.clang12.dwarf2.compressed > 457M vmlinux.clang12.dwarf5 > 536M vmlinux.clang12.dwarf4 > 548M vmlinux.clang12.dwarf2 > > 515M vmlinux.gcc10.2.dwarf5.compressed > 599M vmlinux.gcc10.2.dwarf4.compressed > 624M vmlinux.gcc10.2.dwarf2.compressed > 630M vmlinux.gcc10.2.dwarf5 > 765M vmlinux.gcc10.2.dwarf4 > 809M vmlinux.gcc10.2.dwarf2 > > Though the quality of debug info is harder to quantify; size is not a > proxy for quality. > > Jakub notes: > All [GCC] 5.1 - 6.x did was start accepting -gdwarf-5 as experimental > option that enabled some small DWARF subset (initially only a few > DW_LANG_* codes newly added to DWARF5 drafts). Only GCC 7 (released > after DWARF 5 has been finalized) started emitting DWARF5 section > headers and got most of the DWARF5 changes in... > > Version check GCC so that we don't need to worry about the difference in > command line args between GNU readelf and llvm-readelf/llvm-dwarfdump to > validate the DWARF Version in the assembler feature detection script. > > Link: http://www.dwarfstd.org/doc/DWARF5.pdf > Suggested-by: Arvind Sankar > Suggested-by: Jakub Jelinek > Suggested-by: Masahiro Yamada > Suggested-by: Fangrui Song > Suggested-by: Caroline Tice > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > Makefile | 1 + > include/asm-generic/vmlinux.lds.h | 6 +++++- > lib/Kconfig.debug | 14 ++++++++++++++ > scripts/test_dwarf5_support.sh | 9 +++++++++ > 4 files changed, 29 insertions(+), 1 deletion(-) > create mode 100755 scripts/test_dwarf5_support.sh > > diff --git a/Makefile b/Makefile > index 2430e1ee7c44..45231f6c1935 100644 > --- a/Makefile > +++ b/Makefile > @@ -828,6 +828,7 @@ endif > > dwarf-version-$(CONFIG_DEBUG_INFO_DWARF2) := 2 > dwarf-version-$(CONFIG_DEBUG_INFO_DWARF4) := 4 > +dwarf-version-$(CONFIG_DEBUG_INFO_DWARF5) := 5 > DEBUG_CFLAGS += -gdwarf-$(dwarf-version-y) > ifneq ($(dwarf-version-y)$(LLVM_IAS),21) > # Binutils 2.35+ required for -gdwarf-4+ support. > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index b2b3d81b1535..76ce62c77029 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -829,7 +829,11 @@ > .debug_types 0 : { *(.debug_types) } \ > /* DWARF 5 */ \ > .debug_macro 0 : { *(.debug_macro) } \ > - .debug_addr 0 : { *(.debug_addr) } > + .debug_addr 0 : { *(.debug_addr) } \ > + .debug_line_str 0 : { *(.debug_line_str) } \ > + .debug_loclists 0 : { *(.debug_loclists) } \ > + .debug_rnglists 0 : { *(.debug_rnglists) } \ > + .debug_str_offsets 0 : { *(.debug_str_offsets) } > > /* Stabs debugging sections. */ > #define STABS_DEBUG \ > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 04719294a7a3..987815771ad6 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -274,6 +274,20 @@ config DEBUG_INFO_DWARF4 > It makes the debug information larger, but it significantly > improves the success of resolving variables in gdb on optimized code. > > +config DEBUG_INFO_DWARF5 > + bool "Generate DWARF Version 5 debuginfo" > + depends on GCC_VERSION >= 70000 || CC_IS_CLANG > + depends on $(success,$(srctree)/scripts/test_dwarf5_support.sh $(CC) $(CLANG_FLAGS)) > + help > + Generate DWARF v5 debug info. Requires binutils 2.35, gcc 7.0+, and > + gdb 8.0+. Changes to the structure of debug info in Version 5 allow > + for around 15-18% savings in resulting image and debug info section sizes > + as compared to DWARF Version 4. DWARF Version 5 standardizes previous > + extensions such as accelerators for symbol indexing and the format for > + fission (.dwo/.dwp) files. Users may not want to select this config if > + they rely on tooling that has not yet been updated to support > + DWARF Version 5. > + > endchoice # "DWARF version" > > config DEBUG_INFO_BTF > diff --git a/scripts/test_dwarf5_support.sh b/scripts/test_dwarf5_support.sh > new file mode 100755 > index 000000000000..156ad5ec4274 > --- /dev/null > +++ b/scripts/test_dwarf5_support.sh > @@ -0,0 +1,9 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > + > +# Test that assembler accepts -gdwarf-5 and .file 0 directives, which were bugs > +# in binutils < 2.35. > +# https://sourceware.org/bugzilla/show_bug.cgi?id=25612 > +# https://sourceware.org/bugzilla/show_bug.cgi?id=25614 > +set -e > +echo '.file 0 "filename"' | $* -Wa,-gdwarf-5 -c -x assembler -o /dev/null - > -- > 2.29.2.576.ga3fc446d84-goog >