Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201216022538.7389-1-vichy.kuo@gmail.com> <CAOVJa8FTyX89MWieV3C+NmmDqS4EWi7Aok-j4_Tti_ZmVS050A@mail.gmail.com>
In-Reply-To: <CAOVJa8FTyX89MWieV3C+NmmDqS4EWi7Aok-j4_Tti_ZmVS050A@mail.gmail.com>
Reply-To: cwchoi00@gmail.com
From:   Chanwoo Choi <cwchoi00@gmail.com>
Date:   Tue, 5 Jan 2021 10:03:41 +0900
Message-ID: <CAGTfZH3c18jxC8cXR93Ms8XJeYPTa18oOYUX7WsOvk6G0K=nng@mail.gmail.com>
Subject: Re: [PATCH 1/1] PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device
To:     pierre kuo <vichy.kuo@gmail.com>
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Linux PM list <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Dec 29, 2020 at 12:25 AM pierre kuo <vichy.kuo@gmail.com> wrote:
>
> Hi myungjoo, kyungmin and cw:
> Would you please help to review this patch?
>
> Thanks a lot.
>
> pierre Kuo <vichy.kuo@gmail.com> =E6=96=BC 2020=E5=B9=B412=E6=9C=8816=E6=
=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=8810:26=E5=AF=AB=E9=81=93=EF=BC=
=9A
> >
> > In devfreq_add_device, replace devfreq->dev.parent
> > as dev to keep code simple.
> >
> > Signed-off-by: pierre Kuo <vichy.kuo@gmail.com>
> > ---
> >  drivers/devfreq/devfreq.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index 6aa10de792b3..94cc25fd68da 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > @@ -893,13 +893,13 @@ struct devfreq *devfreq_add_device(struct device =
*dev,
> >                 goto err_devfreq;
> >
> >         devfreq->nb_min.notifier_call =3D qos_min_notifier_call;
> > -       err =3D dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->=
nb_min,
> > +       err =3D dev_pm_qos_add_notifier(dev, &devfreq->nb_min,
> >                                       DEV_PM_QOS_MIN_FREQUENCY);
> >         if (err)
> >                 goto err_devfreq;
> >
> >         devfreq->nb_max.notifier_call =3D qos_max_notifier_call;
> > -       err =3D dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->=
nb_max,
> > +       err =3D dev_pm_qos_add_notifier(dev, &devfreq->nb_max,
> >                                       DEV_PM_QOS_MAX_FREQUENCY);
> >         if (err)
> >                 goto err_devfreq;
> > --
> > 2.17.1
> >

Applied it. Thanks.


--=20
Best Regards,
Chanwoo Choi