Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201214045850.1026293-1-zhang.lyra@gmail.com> <20210104182353.GA935@ninjato>
In-Reply-To: <20210104182353.GA935@ninjato>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Tue, 5 Jan 2021 10:13:29 +0800
Message-ID: <CAAfSe-t-J3ckbwKjNuRpcm0wq7gme7YFG7fiHqLHk-Pu44jwZQ@mail.gmail.com>
Subject: Re: [PATCH v2] i2c: sprd: use a specific timeout to avoid system hang
 up issue
To:     Wolfram Sang <wsa@kernel.org>
Cc:     Baolin Wang <baolin.wang7@gmail.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        Linhua Xu <linhua.xu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 5 Jan 2021 at 02:24, Wolfram Sang <wsa@kernel.org> wrote:
>
> On Mon, Dec 14, 2020 at 12:58:50PM +0800, Chunyan Zhang wrote:
> > From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> >
> > If the i2c device SCL bus being pulled up due to some exception before
> > message transfer done, the system cannot receive the completing interrupt
> > signal any more, it would not exit waiting loop until MAX_SCHEDULE_TIMEOUT
> > jiffies eclipse, that would make the system seemed hang up. To avoid that
> > happen, this patch adds a specific timeout for message transfer.
> >
> > Fixes: 8b9ec0719834 ("i2c: Add Spreadtrum I2C controller driver")
> > Signed-off-by: Linhua Xu <linhua.xu@unisoc.com>
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
>
> Took the liberty to change the errno to ETIMEDOUT and applied to
> for-current, thanks!

Thanks!

Chunyan

>