Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp14285437pxu; Mon, 4 Jan 2021 19:20:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnJxdzG2l4TIhZa+FHyjB+fSfqbUiZa4TdbRy6CztJHH2KDufi8D+nl16hVbVhNHlvtpui X-Received: by 2002:a17:906:3094:: with SMTP id 20mr67465358ejv.218.1609816803768; Mon, 04 Jan 2021 19:20:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609816803; cv=none; d=google.com; s=arc-20160816; b=GR41qTLnziPR8unATPhHxc7SssEtwRWjvqzCSqfxU2YRMxfFicxgnwBo2AIVeh9LlK 01tnckhGnfJ2+d7nPuk9c9/W/mrkCGlSlN9yDdhe5P83LX1yuVqvAQJ1QzY4BlHKv4G1 5sFeugCrJPOqbgYsTGuQWOHFntOcusYUKx+xjM7t+RK1uA29HP5Ol2y+2615Noona5zy 6hrizGw1Bx9wHFBZD6rknIKCt/TyMB0yDfp86uXh5q4NFrrqAT2d5SnFCe8WZcotUdzJ wrtAqD6bYoHtucTRO4CsK5e8GeqSCoStm/MVa2cVzQcHX+jz5GqIqVX+xe+UNzKwWe9O Mdsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=bh/KlAKtf2is8XgpiGQlUbIlz9Cl49eRRpOLayL9zlI=; b=T/IkbgkfIyhHr5ybNm0neJWFna8K2Pr4PPYpbyvJlKPGFWly4rSltSwdzm1HoP3BGT NviXnkEljACWoYIjSMYvC/Xyt74wOlsitQMweShAY3dMDEHs2AXrnj/Ez8O5NZsJRsbe bsmkYsb5ISMg3KyvRpWDAwLc12quARDmuerTA0/uFb4JWW6QFiDnreGqnTUPhajrwcNQ 1fLI/xllPUekMqctnO8UVyCITBK7G8PH/G1JgZzh3+ligViqqCNjzMREyKPHDQ8/djx1 xomehrM67Ey3/S4Y0umHxTIdaGJwuJceP8QrZSiJBXRioQbwM9d0DKU6fhikYSEFQpRe /e5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@iluvatar.ai header.s=key_2018 header.b=jqNgsXGg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iluvatar.ai Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id df21si32393829edb.207.2021.01.04.19.19.40; Mon, 04 Jan 2021 19:20:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@iluvatar.ai header.s=key_2018 header.b=jqNgsXGg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iluvatar.ai Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728304AbhAEDSA (ORCPT + 99 others); Mon, 4 Jan 2021 22:18:00 -0500 Received: from owa.iluvatar.ai ([103.91.158.24]:6093 "EHLO smg.iluvatar.ai" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726599AbhAEDSA (ORCPT ); Mon, 4 Jan 2021 22:18:00 -0500 X-AuditID: 0a650161-e51ff70000001043-b0-5ff3da38862c Received: from owa.iluvatar.ai (s-10-101-1-102.iluvatar.local [10.101.1.102]) by smg.iluvatar.ai (Symantec Messaging Gateway) with SMTP id A4.FB.04163.83AD3FF5; Tue, 5 Jan 2021 11:17:12 +0800 (HKT) Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; d=iluvatar.ai; s=key_2018; c=relaxed/relaxed; t=1609816632; h=from:subject:to:date:message-id; bh=bh/KlAKtf2is8XgpiGQlUbIlz9Cl49eRRpOLayL9zlI=; b=jqNgsXGg612hjuVZr2jcZZfLYgJlk0Q3kQURO63DaAoo5B53K5ZO0mXfQNh+Li7KpodGwuplyTB xp4mBZ3nTq9hfeUINe1GW1IfWRnc0G6bMfjuDGxysgrSJpIx+DZfB7sGTmzpbqldGugE00ZVI526L AVTcDEHqtdITdqxVrD4= Received: from hsj-Precision-5520.iluvatar.local (10.101.199.252) by S-10-101-1-102.iluvatar.local (10.101.1.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Tue, 5 Jan 2021 11:17:12 +0800 From: Huang Shijie To: CC: , , Huang Shijie Subject: [PATCH] lib/genalloc: change return type to unsigned long for bitmap_set_ll Date: Tue, 5 Jan 2021 11:16:44 +0800 Message-ID: <20210105031644.2771-1-sjhuang@iluvatar.ai> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.101.199.252] X-ClientProxiedBy: S-10-101-1-105.iluvatar.local (10.101.1.105) To S-10-101-1-102.iluvatar.local (10.101.1.102) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just as bitmap_clear_ll(), change return type to unsigned long for bitmap_set_ll to avoid the possible overflow in future. Signed-off-by: Huang Shijie --- This patch is not a bug fix. I missed to change it in previous patch. --- lib/genalloc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/genalloc.c b/lib/genalloc.c index dab97bb69df6..5dcf9cdcbc46 100644 --- a/lib/genalloc.c +++ b/lib/genalloc.c @@ -81,7 +81,8 @@ static int clear_bits_ll(unsigned long *addr, unsigned long mask_to_clear) * users set the same bit, one user will return remain bits, otherwise * return 0. */ -static int bitmap_set_ll(unsigned long *map, unsigned long start, unsigned long nr) +static unsigned long +bitmap_set_ll(unsigned long *map, unsigned long start, unsigned long nr) { unsigned long *p = map + BIT_WORD(start); const unsigned long size = start + nr; -- 2.17.1