Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp30992pxu; Tue, 5 Jan 2021 04:28:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSigW7LRermHpMvrp3VhmmdnH9aM9XbkF9YV5RU0Uh55SXTPQR0Mh2GTTC2iHxwV2QH1YO X-Received: by 2002:a50:fc13:: with SMTP id i19mr77448218edr.281.1609849733769; Tue, 05 Jan 2021 04:28:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609849733; cv=none; d=google.com; s=arc-20160816; b=igXMFSpWEutephIJaPIrB7FFVgg0q+C3sYilIKoIZIXfkyqzdnGWCObLuvW/M3E60T z4vtFLNTNQvMubF+uS8HIDxA8XoX+yl7Gakr/+w0Wg/n14Bexbv+Nal5ZfvVeOh8V30d R7rO4C7SfRx2tDI2YdRbk37YYED/YGwQOBz//s9KuoM/u4H//zqqcLx2OZeb8tA3wlG5 jRWAMGVqC5eT+M1uzGUlNObKUenbJHlIrXl0ixRV9JPL21kK4+tNrWMF61Lw1uLdz1rc 6JMLFGD7t4UCqIcMMegPOp2pbj72QJUrncRt9WPCdY6V8g9sj1xtpVV9YG7U2GGPo7v7 Dvng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=eInvQGhTcJyzVENgonnpizd48BCmM0Ah44o/273fhyU=; b=yf1/v/5IiBT4Ytc7LItaLI1yClHh6HCzW4Q/rZkaDc2rdOlk0EKLQMZHaBtvlA6ypM CcpZBfcZNaPDoADqJPOp9QVS7/Wuj9hj33Z6CmjSIZansGEZ9rv+vcoIRspHSoMbKpSa DC+N9yHag8wVAThNQLXZ60N43Xm3v9YRxnXasnb4F6P5f+v5So7/iTzusGYU4sAv2m8U vRJ1t9L1ZvGX0NrLlwN6qn6s0DxzpfW+aUbWquyIOE0qitR+tKhYKYvF+io0+9/HbkeG Eb3g2Tng8xyFehAMK9PD4x2jcD7VwdJ/9djQHVjDeJ4IOGzBU5fgni/23UTgJxZebmEp aIGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n16si34332419edb.217.2021.01.05.04.28.30; Tue, 05 Jan 2021 04:28:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728126AbhAEKJd (ORCPT + 99 others); Tue, 5 Jan 2021 05:09:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:57060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbhAEKJd (ORCPT ); Tue, 5 Jan 2021 05:09:33 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2890C224F9; Tue, 5 Jan 2021 10:08:50 +0000 (UTC) Date: Tue, 5 Jan 2021 10:08:47 +0000 From: Catalin Marinas To: Keqian Zhu Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Marc Zyngier , Will Deacon , Mark Rutland , Robin Murphy , Joerg Roedel , James Morse , Suzuki K Poulose , Julien Thierry , wanghaibin.wang@huawei.com Subject: Re: [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts() Message-ID: <20210105100847.GB11802@gaia> References: <20210105092221.15144-1-zhukeqian1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105092221.15144-1-zhukeqian1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2021 at 05:22:21PM +0800, Keqian Zhu wrote: > The local variable irq is added in commit a26388152531 ("arm64: > Remove custom IRQ stat accounting"), but forget to remove in > commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in > arch_show_interrupts()"). Just remove it. > > Signed-off-by: Keqian Zhu I already queued a similar fix in arm64 for-next/fixes (it should appear in linux-next at some point). -- Catalin