Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp33762pxu; Tue, 5 Jan 2021 04:33:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEENHrCtUiiw8HGsVPKtUlm8AUXDpINzgHVvDYYLO1CpKMrgO0eqD/xT7gWRAy+CujCotr X-Received: by 2002:a17:906:7e0b:: with SMTP id e11mr69038930ejr.533.1609850020395; Tue, 05 Jan 2021 04:33:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609850020; cv=none; d=google.com; s=arc-20160816; b=hNFyJ3qU6Q8LDDD1IY+lVGD26EJftwOAsxUKfds/7lW5t+Ewm8qwtajlLXFNQTHQgU r+SLVCNifUJ1665mLuej8iUFeKXvu5TPilSrNPVHndE3YtGWO15xwmPGEIfao/r/dnH7 myk7umGUDH7EzmermlKedcHpOsRFSb1fxSgVTTC3HQ9GmOM/kb3gjbHCDKpwuwHW6UQo 1+F+DN4AWluPR5B0IKBThtFtKJyu28T+X1bKO5KuIouJtHjSgImQrq4okx3PwFwCbVYb JleFQRLmDQEussK2J4kZi+faioknLpGl8DtwPZFJrRxfyFqWVk4/kr2iYNHz7lb8nbEh 1DRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=A3SqENQkYPHJ8akSJ6bP7mwsChg/fqGV+2IF29zn894=; b=shs1s1Xap0hoex+m5p8ISnmfNMS61Rp+JUsxam0sEIiV9H7y6rixqjQYHLn7dFVMfJ iNTpgqoUpauPPPjncUlyxHgsu6gmAj7xYVhjzaM8vcS/mupprKLrW+Z1ZhA7wBHccqgK R2C7I1z9MBS5schrimJpDsvvuDY1sgtXv+0hHxK22UayrnGKQEZT2JNiwOVfWt2pvw2D V2/7mTjru9bsrgTdK+U7eTnrAaOzXuQmlAEKcoaQcIPLteq+i0zHpIHcexWkXy/mTNw3 +n4Ba2OUvRmd/h46vdS6VT8WjyKNYxqDeA7yJAn8dEDdBX1p/+n5GxegEW/UgTLfgthh roYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lm18si29088056ejb.160.2021.01.05.04.33.17; Tue, 05 Jan 2021 04:33:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729364AbhAEKtH (ORCPT + 99 others); Tue, 5 Jan 2021 05:49:07 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:10109 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727764AbhAEKtG (ORCPT ); Tue, 5 Jan 2021 05:49:06 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4D98Mj740dz15nlp; Tue, 5 Jan 2021 18:47:29 +0800 (CST) Received: from [10.174.184.42] (10.174.184.42) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Tue, 5 Jan 2021 18:48:18 +0800 Subject: Re: [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts() To: Catalin Marinas References: <20210105092221.15144-1-zhukeqian1@huawei.com> <20210105100847.GB11802@gaia> CC: , , , , Marc Zyngier , Will Deacon , Mark Rutland , Robin Murphy , Joerg Roedel , James Morse , Suzuki K Poulose , Julien Thierry , From: Keqian Zhu Message-ID: Date: Tue, 5 Jan 2021 18:48:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20210105100847.GB11802@gaia> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.184.42] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/1/5 18:08, Catalin Marinas wrote: > On Tue, Jan 05, 2021 at 05:22:21PM +0800, Keqian Zhu wrote: >> The local variable irq is added in commit a26388152531 ("arm64: >> Remove custom IRQ stat accounting"), but forget to remove in >> commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in >> arch_show_interrupts()"). Just remove it. >> >> Signed-off-by: Keqian Zhu > > I already queued a similar fix in arm64 for-next/fixes (it should appear > in linux-next at some point). > OK, I see. Thanks.