Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 5 Jan 2021 14:31:57 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Md Sadre Alam <mdalam@codeaurora.org>
Cc:     manivannan.sadhasivam@linaro.org, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org, boris.brezillon@collabora.com,
        vigneshr@ti.com, sricharan@codeaurora.org
Subject: Re: [PATCH V2] mtd: rawnand: qcom: update last code word register
Message-ID: <20210105143157.6262f7d5@xps13>
In-Reply-To: <1609785078-22310-1-git-send-email-mdalam@codeaurora.org>
References: <1609785078-22310-1-git-send-email-mdalam@codeaurora.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hello,

Md Sadre Alam <mdalam@codeaurora.org> wrote on Tue,  5 Jan 2021
00:01:18 +0530:

> From QPIC version 2.0 onwards new register got added to
> read last codeword. This change will update the same.
> 
> For first three code word READ_LOCATION_n register will be
> use.For last code wrod READ_LOCATION_LAST_CW_n register will be

s/wrod/word

> use.
> 

Please add a Fixes tag here

> Signed-off-by: Md Sadre Alam <mdalam@codeaurora.org>
> ---
> [V2]
>  * Fixed alignment for NAND_READ_LOCATION_LAST_CW_n reg macro
>  * Changed number of register write to 1 when NAND_READ_LOCATION_LAST_CW_n register will use
>  drivers/mtd/nand/raw/qcom_nandc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index eaef51d..9e89236 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -48,10 +48,10 @@
>  #define	NAND_READ_LOCATION_1		0xf24
>  #define	NAND_READ_LOCATION_2		0xf28
>  #define	NAND_READ_LOCATION_3		0xf2c
> -#define NAND_READ_LOCATION_LAST_CW_0    0xf40
> -#define NAND_READ_LOCATION_LAST_CW_1    0xf44
> -#define NAND_READ_LOCATION_LAST_CW_2    0xf48
> -#define NAND_READ_LOCATION_LAST_CW_3    0xf4c
> +#define	NAND_READ_LOCATION_LAST_CW_0	0xf40
> +#define	NAND_READ_LOCATION_LAST_CW_1	0xf44
> +#define	NAND_READ_LOCATION_LAST_CW_2	0xf48
> +#define	NAND_READ_LOCATION_LAST_CW_3	0xf4c

It looks like you forgot to squash this to you original patch :)

>  
>  /* dummy register offsets, used by write_reg_dma */
>  #define	NAND_DEV_CMD1_RESTORE		0xdead
> @@ -1125,7 +1125,7 @@ config_nand_cw_read(struct qcom_nand_controller *nandc, bool use_ecc)
>  	if (nandc->props->is_bam) {
>  		if (nandc->props->qpic_v2)
>  			write_reg_dma(nandc, NAND_READ_LOCATION_LAST_CW_0,
> -				      4, NAND_BAM_NEXT_SGL);
> +				      1, NAND_BAM_NEXT_SGL);
>  		write_reg_dma(nandc, NAND_READ_LOCATION_0, 4,
>  			      NAND_BAM_NEXT_SGL);
>  	}

Thanks,
Miquèl