Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp104727pxu; Tue, 5 Jan 2021 06:22:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWpx2ygzzFb1n28/ubO8C76HDiyAB7/n0415oSCwOdlomKvXd2C6CWmvosTYBTBe4kIIGK X-Received: by 2002:a50:d484:: with SMTP id s4mr75788999edi.13.1609856521869; Tue, 05 Jan 2021 06:22:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609856521; cv=none; d=google.com; s=arc-20160816; b=S4lxOtdMga/miVKnTWxLNrm/T5KsOXuDIBe9pzkAi7NNDhPBE9xCi76CHX6nwrzLzv qnFQyujCJIHetY5Lp6Rf8rNX50VyB7fjniCp/tNfCiU+cFYJ89rT2VCZlemGPwlm8ZO/ 3SRtmSPV9QIcppqT3qsm9WEopHOgamp3A2wa6rHqSSVpkij3pTC658L3o/YNFHAtemJp pSaN32Y7u+V1/71TBmXeIIqQJyZDCsmzYKKNJvItGaVmYrRr0gE1Oq7HHRtOHL8wxoD9 id6zWcSKVNvS40r6vPyWLOkpk3GpvoXf8AhLrerhImfanugpctp7zB77QrqjV4CkgoNN WGyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=VYAOVPzTCDHPVHPsBdE7ahRv/jF/NxuZ8z4HhpbF+Cc=; b=eJWz4xQkrVCTb2Mqf0/MFN4gMJh3Gq+BWxkeqlacH2IWaVhf/icjdnZt1xESUbiOKR Mogbo8rYPki71Tz522/4y2JGJuT5lXo/LpMaK89Q9xkC9tHYqCk/jaA7f3p6760dGLtA P8oiMub/10+0aD/UJFwCmLrM2ho6SVIGH/NjivZHJtS6d6WnCalSZPZFLphsgMuUU5kB SeOHa0EdtFMIiM781ecKM9heb/ChEbQzuqvONNC48INTJRYO03N6r9feUXTAluTv/bir rCsFuDRhiO0yZZLJNVIXF3+nVwHvuFDjN4QfmbAlbO3PU4OOvE0neoRdPibmqGny98/t vATQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=SE0oq+04; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si32379241edx.226.2021.01.05.06.21.38; Tue, 05 Jan 2021 06:22:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=SE0oq+04; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727379AbhAEOTL (ORCPT + 99 others); Tue, 5 Jan 2021 09:19:11 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:39518 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbhAEOTK (ORCPT ); Tue, 5 Jan 2021 09:19:10 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 105EF1aM101866; Tue, 5 Jan 2021 14:17:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=VYAOVPzTCDHPVHPsBdE7ahRv/jF/NxuZ8z4HhpbF+Cc=; b=SE0oq+04evcDpFCjnKCLQPghRdLeNiXKbdU2N0XIAneKqhhzf23Zvr79nCj8PgDZKeBT Vrqmx/XGHjN15zW1ms4epwzNQU5uj94H9vI06S/3WMQWRUytPnmRXAruAVks8DE3bv1G le2GF33B/dwqudcnfm0TqscsGKjG3i4pChHv06qu/Jaxo5g2v298+cgEEHN15WZqM1Pa B4181mm3j3g1x2aogtZ9kHR2deCn6ZcTqVaFJ+M6U4kGSKYN6TYQZ1rcTZyGKnUyJkws woTjsAK9x83V48WFDhK1Pv1WqicOxw/ooBYKIrRKgV495PxV+vxmLPaKSMPBEI0JfThD Qg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 35tgskrxp7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 05 Jan 2021 14:17:59 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 105EAlHG005518; Tue, 5 Jan 2021 14:17:58 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 35v1f8nbc7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Jan 2021 14:17:58 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 105EHghU011314; Tue, 5 Jan 2021 14:17:42 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Jan 2021 14:17:41 +0000 Date: Tue, 5 Jan 2021 17:17:01 +0300 From: Dan Carpenter To: Xin Ji Cc: Nicolas Boichat , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , devel@driverdev.osuosl.org, Jernej Skrabec , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vasily Khoruzhick , Boris Brezillon , Torsten Duwe , Sheng Pan , Daniel Vetter , Hsin-Yi Wang , Sam Ravnborg , Marek Szyprowski Subject: Re: [PATCH v2 2/2] drm/bridge: anx7625: add MIPI DPI input feature support Message-ID: <20210105141701.GG2809@kadam> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9854 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101050090 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9854 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101050090 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 31, 2020 at 10:22:36AM +0800, Xin Ji wrote: > static int anx7625_read_ctrl_status_p0(struct anx7625_data *ctx) > { > return anx7625_reg_read(ctx, ctx->i2c.rx_p0_client, AP_AUX_CTRL_STATUS); > @@ -189,10 +203,64 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) > AP_AUX_CTRL_STATUS); > if (val < 0 || (val & 0x0F)) { > DRM_DEV_ERROR(dev, "aux status %02x\n", val); > - val = -EIO; > + return -EIO; > } > > - return val; > + return 0; This s/val/0/ change seems like a bug fix. Could you please send that as a separate patch at the start of the patch set? > +} regards, dan carpenter