Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp110662pxu; Tue, 5 Jan 2021 06:31:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJx0HrgrgLGOmlXjPuG4YyHb/j8Htl8DafyD9GLwwLcDKNXwoFX4gqtGEvnuj5K4tiA1scgU X-Received: by 2002:a17:906:3bcd:: with SMTP id v13mr70739982ejf.181.1609857072383; Tue, 05 Jan 2021 06:31:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609857072; cv=none; d=google.com; s=arc-20160816; b=Bj+PE22QF3yeZY66C/hQbSi2j55i5tMJy+7zZH+UMARDjjP8+o2yrd6gfhaD8LmLcJ V4XYJa+wuFDzkhzfLaMUfsg084Ook2lHQ0DhIUSKKllBUkiuv/xoxvPTsuXseAfLVHJv r36OE9A9jRfNty2pFa5NAL6J9rukCWx1fHWnvgmiIryw4G3xUh8yH7L6gogmwQK5rNtU E3JSSJ0KvUQGNhQChUqvmGFfHbVziwJc07fia1yLScjJlUbPhivrjmoH3bZvKuqqZ4GM /dw8ZmMzQAa7dpgMJEgjNkl8SqbIuMcVI2WNFu/Ue5mpoApIIger7eiskLETO+Fo3IVK qkng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WPt4GbgvCJj/QsPuZwFr/Sd2QDQgrOU3f9zQkLRLZCE=; b=WYYRobgncKjJwWxsZ8FR2vEmk+0JrL0yuf1eBJuPCFJQV0fi/gzjs0zN9Du6cpEXXO RmuWruCrlJVyJP8LvDt9nXJnpIOXo7EBsON756Ep+4pbJ+eyova9Z9+4iPfaEKV1zaWx cGjdeHS8DoM077+6Xs+umFLQXcKU/BQR8bLV9JHDIBfaCiuMKuPys/bxbu+PxUqCOoNe eafrcgdvYdC64jMdrYeULNDufR1+jodRmEuPfYC4vI93LYzrAwAeVAReJAlZ+I1hrpR1 QPpb04V6Uxs3NfmZDgjw8kTMl3ZFlv22J/cOvyzBRkeS763EznhSZ3C3xykzA0uh8SQk 0Cwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=VshOaC0G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si32354139edt.283.2021.01.05.06.30.48; Tue, 05 Jan 2021 06:31:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=VshOaC0G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbhAEO1p (ORCPT + 99 others); Tue, 5 Jan 2021 09:27:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727005AbhAEO1o (ORCPT ); Tue, 5 Jan 2021 09:27:44 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55FC5C061795 for ; Tue, 5 Jan 2021 06:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WPt4GbgvCJj/QsPuZwFr/Sd2QDQgrOU3f9zQkLRLZCE=; b=VshOaC0GH4R/GHWLsOrEaR8b2K f1iVB2FdwmZspXhWCtXhYE0GQ+yD/lw0u3Gu3dCbCNz13IM4rb22OcMQwgeEUHxl59jRWfCCWdTLf SG8aDNnaltBNlBEXR/znh11f4cffx+/uqrDDigCA60AwXTif2IMu9dTSIxq/oUf1nXwXXoUI5N0zU WdXCQt6Z4Bl4Z8tlEQutzgQtBVXUgAUjNEPmQoXV3NO0bmwTyDvSS6l4ynZk1xvwrkVkdKU/bK5mg 6vqcdVrvcdmg+ulkaE5YZq7M5aACoMBNmaz0qBh27/+cI/0oEu5UOwR8sW0yodinZPb3sqVCFQLcC WtDxcDsA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwnIR-0000DE-BP; Tue, 05 Jan 2021 14:26:51 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id B3A4730377D; Tue, 5 Jan 2021 15:26:48 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9EE9621210122; Tue, 5 Jan 2021 15:26:48 +0100 (CET) Date: Tue, 5 Jan 2021 15:26:48 +0100 From: Peter Zijlstra To: Nadav Amit Cc: Andrea Arcangeli , linux-mm , lkml , Yu Zhao , Andy Lutomirski , Peter Xu , Pavel Emelyanov , Mike Kravetz , Mike Rapoport , Minchan Kim , Will Deacon , Mel Gorman Subject: Re: [RFC PATCH v2 1/2] mm/userfaultfd: fix memory corruption due to writeprotect Message-ID: <20210105142648.GJ3040@hirez.programming.kicks-ass.net> References: <20201225092529.3228466-1-namit@vmware.com> <20201225092529.3228466-2-namit@vmware.com> <20210104122227.GL3021@hirez.programming.kicks-ass.net> <20210105081325.GD3040@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2021 at 12:52:48AM -0800, Nadav Amit wrote: > > On Jan 5, 2021, at 12:13 AM, Peter Zijlstra wrote: > > > > On Mon, Jan 04, 2021 at 02:24:38PM -0500, Andrea Arcangeli wrote: > >> The problematic one not pictured is the one of the wrprotect that has > >> to be running in another CPU which is also isn't picture above. More > >> accurate traces are posted later in the thread. > > > > What thread? I don't seem to have discovered it yet, and the cover > > letter from Nadav doesn't seem to have a msgid linking it either. > > Sorry for that: > > https://lore.kernel.org/lkml/X+K7JMrTEC9SpVIB@google.com/T/ Much reading later.. OK, go with the write-lock for now.