Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210104065843.5658-1-songmuchun@bytedance.com>
In-Reply-To: <20210104065843.5658-1-songmuchun@bytedance.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Tue, 5 Jan 2021 10:04:44 -0800
Message-ID: <CAHbLzkpNKzL052VQxFaOnwSGSMMFDzZotk8KRa_4LVZfO134ZQ@mail.gmail.com>
Subject: Re: [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose
 refcount is one
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     Mike Kravetz <mike.kravetz@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        hillf.zj@alibaba-inc.com,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        ak@linux.intel.com, yongjun_wei@trendmicro.com.cn, mhocko@suse.cz,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jan 3, 2021 at 11:01 PM Muchun Song <songmuchun@bytedance.com> wrote:
>
> If the refcount is one when it is migrated, it means that the page
> was freed from under us. So we are done and do not need to migrate.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/migrate.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 4385f2fb5d18..a6631c4eb6a6 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1279,6 +1279,12 @@ static int unmap_and_move_huge_page(new_page_t get_new_page,
>                 return -ENOSYS;
>         }
>
> +       if (page_count(hpage) == 1) {
> +               /* page was freed from under us. So we are done. */
> +               putback_active_hugepage(hpage);
> +               return MIGRATEPAGE_SUCCESS;
> +       }
> +

Acked-by: Yang Shi <shy828301@gmail.com>

>         new_hpage = get_new_page(hpage, private);
>         if (!new_hpage)
>                 return -ENOMEM;
> --
> 2.11.0
>
>