Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp349698pxu; Tue, 5 Jan 2021 12:45:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1hSLNMGIHPmygzmIJc5LzeITwN5BGE9iZQdIMBgcDisAAWoIqhyUEumsF/Qr8q3CQJ7sy X-Received: by 2002:a17:906:d784:: with SMTP id pj4mr781660ejb.360.1609879520510; Tue, 05 Jan 2021 12:45:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609879520; cv=none; d=google.com; s=arc-20160816; b=r8WOxm7aebozrKYfqsHiP/yFBJWoiVR1w8y+e+3fO1OO6FtflMd/TCKqWzmWfVa+g3 R5N6hLmKSo76D6ZgWWa5UaS9D2K77u2CoIvXjAGQE5p5j4Sba+1aK9Qj9ULScVbTKUyo 32AZTaMxlxGmDCWXZwD81g7X+fdmeXCsqiWdPltAGFIrjzBLDwI8IOQOyhnLChK9Fs7r 3o514WZI2BbNtbIZv7eP7+NnTvuTUbF2pNQbY7lr/USAgOcdiRF9wpJe8WacqD/wPDN3 MIkuYQPrdp1HO4UJGOlpiwodJ44Nu1mg8fpvJ6kjaqGGAkl8TdlVOPFEvya1i8XTaf2k /axA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=gYrYl6lwVMKE6AZZY3N9fd1OI5CXgyH19inYEZdqeMI=; b=OAOJO95VAoU7tHfo7/Sywaj+jEvMBts9Iegcovh54HW/ePAGMOrcWrNDFceQYxCvqY yma4okyax+0Y2C2vvMi5qRTw1MVtSgHmEF4nG1BlCMt0Nsb2o7X1QQ3LC98Zz0bMFJg1 EhFhovxFBs9oF85B7a2keyJ0DsqXo1HjRPpihJgGT3gUmEIokZhW5QhxaoC57en5Lznh /MaCnDDkLiGIpoMrVdvAmDzJl8nfIGP9y4DrDLGDwgbyCsfoHuQkgc3xfrECmK6AYP2i yF1zUk8dvq6GuJ5p5yt+PPFxUnl4yJthwNv9cxQDqfBrYEiZF+JmAnWU+a9Sbd84vuBd TXsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FFvV6gPH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx8si102461ejb.664.2021.01.05.12.44.57; Tue, 05 Jan 2021 12:45:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FFvV6gPH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727304AbhAENPL (ORCPT + 99 others); Tue, 5 Jan 2021 08:15:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:60178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbhAENPK (ORCPT ); Tue, 5 Jan 2021 08:15:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 72592229EF; Tue, 5 Jan 2021 13:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609852469; bh=wlbXdg6aRtpgKOPhZD6u58GmHEX7rXwhsiEi0BFoGUA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FFvV6gPH/dp3pR/eYC7RAni2FwPHbLeBH1AgxWnXbXN3vP98pMigiUNczCiBzxqOm KUhsanU8V2BDwuRW6ObwvTsXGP5dSDzoahPobzpSMOe1wlhLxrWyQHMUdvAoRZ9fV7 xNV8uo9lch1xLBp/Fqw+sY1PNhhnnbT8Uv9aNMfGPrP96QgpP/wdiNXWHtSwgGD1gk C4KGbPbI6THsxwtH0POumuKzhzkeOmxHpuOdk4JULmzHLTQTXSPi6ihuQXAQoLJa49 NgEkpb6pTaky+WiU7Tv8WUjOyXrQW1pErNWtVSPeE/tt6P838esJEHNsCO620APwaE sfCGBZKatmkGQ== From: Felipe Balbi To: Wesley Cheng , peter.chen@nxp.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Wesley Cheng Subject: Re: [PATCH 2/3] usb: gadget: composite: Split composite reset and disconnect In-Reply-To: <1609283011-21997-3-git-send-email-wcheng@codeaurora.org> References: <1609283011-21997-1-git-send-email-wcheng@codeaurora.org> <1609283011-21997-3-git-send-email-wcheng@codeaurora.org> Date: Tue, 05 Jan 2021 15:14:24 +0200 Message-ID: <87k0srcyq7.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Wesley Cheng writes: > +void composite_reset(struct usb_gadget *gadget) > +{ > + /* > + * Section 1.4.13 Standard Downstream Port of the USB battery charging > + * specification v1.2 states that a device connected on a SDP shall only > + * draw at max 100mA while in a connected, but unconfigured state. The requirements are different, though. I think OTG spec has some extra requirements where only 8mA can be drawn max. You need to check for the otg flag. Moreover, USB3+ spec has units of 150mA meaning the device can't draw 100mA (IIRC). -- balbi